Support complex number list in JIT by anjali411 · Pull Request #51145 · pytorch/pytorch

anjali411 · 2021-01-26T22:05:11Z

Stack from ghstack:

Support complex number list in JIT #51145 Support complex number list in JIT

Differential Revision: D26154025

[ghstack-poisoned]

ghstack-source-id: 99d6bb5 Pull Request resolved: #51145

facebook-github-bot · 2021-01-26T22:05:28Z

💊 CI failures summary and remediations

As of commit 8a9ae4c (more details on the Dr. CI page):

1/2 failures introduced in this PR
1/2 broken upstream at merge base 1836070 on Jan 26 from 12:49pm to 5:48pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_python_doc_build (1/1)

Step: "Doc Build and Push" (full log | diagnosis details | 🔁 rerun)

Feb 01 04:40:51 Makefile:38: recipe for target 'html' failed

Feb 01 04:40:50 
Feb 01 04:40:50 copying static files... ... done
Feb 01 04:40:50 copying extra files... done
Feb 01 04:40:51 dumping search index in English (code: en)... done
Feb 01 04:40:51 dumping object inventory... done
Feb 01 04:40:51 build finished with problems, 1 warning.
Feb 01 04:40:51 /var/lib/jenkins/workspace/docs/src/pytorch-sphinx-theme/pytorch_sphinx_theme/search.html:21: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.
Feb 01 04:40:51   <p class="last">
Feb 01 04:40:51 /var/lib/jenkins/workspace/docs/src/pytorch-sphinx-theme/pytorch_sphinx_theme/search.html:24: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead.
Feb 01 04:40:51   </p>
Feb 01 04:40:51 Makefile:38: recipe for target 'html' failed
Feb 01 04:40:51 make: *** [html] Error 1
Feb 01 04:40:51 ++ code=2
Feb 01 04:40:51 ++ '[' 2 -ne 0 ']'
Feb 01 04:40:51 ++ set +x
Feb 01 04:40:51 =========================
Feb 01 04:40:51 /var/lib/jenkins/workspace/docs/source/notes/broadcasting.rst:6: WARNING: 'any' reference target not found: numpy.doc.broadcasting
Feb 01 04:40:51 =========================
Feb 01 04:40:51 Docs build failed. If the failure is not clear, scan back in the log
Feb 01 04:40:51 for any WARNINGS or for the line build finished with problems
Feb 01 04:40:51 (tried to echo the WARNINGS above the ==== line)

1 job timed out:

pytorch_linux_xenial_py3_clang5_asan_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

pytorch_linux_xenial_py3_clang5_asan_test1 on Jan 26 from 12:49pm to 5:48pm (a949d7b - 5748410)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

SplitInfinity

I'm not sure if this is ready for review (I didn't check if you requested review already, oops) but there are a few distracting formatting changes, and there should be Python tests that use lists of complex numbers.

SplitInfinity · 2021-01-26T22:09:35Z

  const FunctionSchema& forward_schema = getMethod("forward").getSchema();
  std::string input_types = getSchemaInputTypesString(forward_schema);
  const std::vector<Argument>& forward_args = forward_schema.arguments();
-   


There seem to be a lot of formatting changes below this point. Can you undo them?

[ghstack-poisoned]

ghstack-source-id: b7c2bb8 Pull Request resolved: #51145

[ghstack-poisoned]

ghstack-source-id: 23a086f Pull Request resolved: #51145

[ghstack-poisoned]

ghstack-source-id: 46f5840 Pull Request resolved: #51145

anjali411 · 2021-01-28T00:50:59Z

@SplitInfinity ready for review. Added the python test, but can't find a way to update that file without causing those formatting changes

[ghstack-poisoned]

ghstack-source-id: 6c71350 Pull Request resolved: #51145

SplitInfinity

Nice!

SplitInfinity · 2021-01-29T21:10:35Z

+  ASSERT_EQ(foo12.toComplexDouble(), c10::complex<double>(3,4));
+  ASSERT_EQ(foo1.use_count(), 2);
+  ASSERT_TRUE(baz1.toComplexDoubleVector() == std::vector<c10::complex<double>>({(3, 4), (3, -4), (5, 0)}));
+  IValue the_complex_list(


Seems a bit weird to call this a list when it is a tuple.

true updated the name!

SplitInfinity · 2021-01-29T21:11:42Z

+    def test_complexlist(self):
+        def fn(a: List[complex], idx: int):
+            return a[idx]
+
+        input = [1j, 2, 3 + 4j, -5, -7j]


What about serialization of lists? Is that coming later?

will add it in a follow-up PR

SplitInfinity · 2021-01-29T21:15:14Z

-    bool fast_path_list =
-        val.isBoolList() || val.isIntList() || val.isDoubleList();
+    bool fast_path_list = val.isBoolList() || val.isIntList() ||
+        val.isDoubleList() || val.isComplexDoubleList();


As I recall, complex literals are not supported in TorchScript yet, so this is not being tested.

Differential Revision: [D26154025](https://our.internmc.facebook.com/intern/diff/D26154025) [ghstack-poisoned]

ghstack-source-id: 5a13a5b Pull Request resolved: #51145

SplitInfinity

Nice

Differential Revision: [D26154025](https://our.internmc.facebook.com/intern/diff/D26154025) [ghstack-poisoned]

ghstack-source-id: c575e07 Pull Request resolved: #51145

facebook-github-bot · 2021-02-01T09:24:13Z

@anjali411 merged this pull request in 508bab4.

Summary: Pull Request resolved: pytorch#51145 Test Plan: Imported from OSS Reviewed By: SplitInfinity Differential Revision: D26154025 Pulled By: anjali411 fbshipit-source-id: 74645f9b6467757ddb9d75846e778222109848f0

Support complex number list in JIT

14106fc

[ghstack-poisoned]

This was referenced Jan 26, 2021

Add type annotation logic for complex numbers #50884

Closed

Add serialization logic for complex numbers #50885

Closed

facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 26, 2021

anjali411 added a commit that referenced this pull request Jan 26, 2021

Support complex number list in JIT

4e860de

ghstack-source-id: 99d6bb5 Pull Request resolved: #51145

SplitInfinity reviewed Jan 26, 2021

View reviewed changes

Update on "Support complex number list in JIT"

0831608

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 27, 2021

Support complex number list in JIT

b4ca651

ghstack-source-id: b7c2bb8 Pull Request resolved: #51145

Update on "Support complex number list in JIT"

c84a694

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 27, 2021

Support complex number list in JIT

65281c1

ghstack-source-id: 23a086f Pull Request resolved: #51145

Update on "Support complex number list in JIT"

2a8914a

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 28, 2021

Support complex number list in JIT

631b88c

ghstack-source-id: 46f5840 Pull Request resolved: #51145

anjali411 requested a review from SplitInfinity January 28, 2021 03:01

Update on "Support complex number list in JIT"

a3d1cb2

[ghstack-poisoned]

Update on "Support complex number list in JIT"

635384c

[ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 29, 2021

Support complex number list in JIT

171f35f

ghstack-source-id: 6c71350 Pull Request resolved: #51145

anjali411 added the module: complex Related to complex number support in PyTorch label Jan 29, 2021

SplitInfinity reviewed Jan 29, 2021

View reviewed changes

Update on "Support complex number list in JIT"

41c4fc5

Differential Revision: [D26154025](https://our.internmc.facebook.com/intern/diff/D26154025) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Jan 29, 2021

Support complex number list in JIT

1b848f2

ghstack-source-id: 5a13a5b Pull Request resolved: #51145

SplitInfinity approved these changes Jan 29, 2021

View reviewed changes

Update on "Support complex number list in JIT"

3a3443a

Differential Revision: [D26154025](https://our.internmc.facebook.com/intern/diff/D26154025) [ghstack-poisoned]

Update on "Support complex number list in JIT"

8a9ae4c

Differential Revision: [D26154025](https://our.internmc.facebook.com/intern/diff/D26154025) [ghstack-poisoned]

anjali411 added a commit that referenced this pull request Feb 1, 2021

Support complex number list in JIT

1e6b04c

ghstack-source-id: c575e07 Pull Request resolved: #51145

facebook-github-bot closed this in 508bab4 Feb 1, 2021

facebook-github-bot added the Merged label Feb 1, 2021

facebook-github-bot deleted the gh/anjali411/91/head branch February 4, 2021 15:22

Conversation

anjali411 commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jan 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 1 new failure recognized by patterns

pytorch_python_doc_build (1/1)

🚧 1 fixed upstream failure:

Uh oh!

SplitInfinity left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anjali411 commented Jan 28, 2021

Uh oh!

SplitInfinity left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SplitInfinity left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anjali411 commented Jan 26, 2021 •

edited

Loading

facebook-github-bot commented Jan 26, 2021 •

edited

Loading