[nnc] Refactor generation of intrinsics to reduce the amount of macro-hell#51125
Closed
bertmaher wants to merge 7 commits intogh/bertmaher/57/basefrom
Closed
[nnc] Refactor generation of intrinsics to reduce the amount of macro-hell#51125bertmaher wants to merge 7 commits intogh/bertmaher/57/basefrom
bertmaher wants to merge 7 commits intogh/bertmaher/57/basefrom
Conversation
…-hell The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 2e9b866 (more details on the Dr. CI page):
1 failure not recognized by patterns:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…nt of macro-hell" The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
bertmaher
added a commit
that referenced
this pull request
Jan 26, 2021
…-hell Pull Request resolved: #51125 The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. ghstack-source-id: 120425678 Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/)
…nt of macro-hell" The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
This was referenced Jan 27, 2021
…nt of macro-hell" The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
…ing on "[nnc] Refactor generation of intrinsics to reduce the amount of macro-hell" The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
ZolotukhinM
approved these changes
Jan 27, 2021
ZolotukhinM
left a comment
There was a problem hiding this comment.
Awesome, looks much cleaner now! I didn't check the logic assuming it stays the same.
…nt of macro-hell" The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
… Refactor generation of intrinsics to reduce the amount of macro-hell" The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. Differential Revision: [D26078384](https://our.internmc.facebook.com/intern/diff/D26078384/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 1114fd6. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…-hell (pytorch#51125) Summary: Pull Request resolved: pytorch#51125 The big pile of X-macros used for emitting (possibly vectorized) intrinsics makes it **really** difficult to change that code in any systematic way (which I'm about to do in a later diff). We can factor most of what the macro does into a fairly simple function. There are still macros but they're just a bunch of case/call helper/break boilerplate. ghstack-source-id: 120614089 Test Plan: `buck test mode/opt -c python.package_style=inplace //caffe2/benchmarks/cpp/tensorexpr:bench_ops` Reviewed By: ZolotukhinM Differential Revision: D26078384 fbshipit-source-id: 843548033f73d88c5d9a031c285b92f73be21390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The big pile of X-macros used for emitting (possibly vectorized)
intrinsics makes it really difficult to change that code in any systematic
way (which I'm about to do in a later diff).
We can factor most of what the macro does into a fairly simple function. There
are still macros but they're just a bunch of case/call helper/break
boilerplate.
Differential Revision: D26078384