Closed
Conversation
`ResolutionCallback` returns `py::object` (i.e. `Any`) rather than `py::function` (i.e. `Callable`) Discovered while debugging test failures after updating pybind11 This also makes resoution code slightly faster, as it eliminates casts from object to function and back for every `py::object obj = rcb_(name);` statement.
Contributor
💊 CI failures summary and remediationsAs of commit a720b24 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jamesr66a
approved these changes
Jan 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #51089 +/- ##
==========================================
- Coverage 80.97% 80.90% -0.07%
==========================================
Files 1919 1924 +5
Lines 209785 210014 +229
==========================================
+ Hits 169875 169921 +46
- Misses 39910 40093 +183 |
walterddr
reviewed
Jan 26, 2021
walterddr
approved these changes
Jan 26, 2021
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: `ResolutionCallback` returns `py::object` (i.e. `Any`) rather than `py::function` (i.e. `Callable`) Discovered while debugging test failures after updating pybind11 This also makes resolution code slightly faster, as it eliminates casts from object to function and back for every `py::object obj = rcb_(name);` statement. Pull Request resolved: pytorch#51089 Reviewed By: jamesr66a Differential Revision: D26069295 Pulled By: malfet fbshipit-source-id: 6876caf9b4653c8dc8e568aefb6778895decea05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolutionCallbackreturnspy::object(i.e.Any) rather thanpy::function(i.e.Callable)Discovered while debugging test failures after updating pybind11
This also makes resolution code slightly faster, as it eliminates casts from object to function and back for every
py::object obj = rcb_(name);statement.