Skip to content

[PT QNNPACK] Temporarily disable input pointer caching#51051

Closed
kimishpatel wants to merge 1 commit intopytorch:masterfrom
kimishpatel:export-D25984429
Closed

[PT QNNPACK] Temporarily disable input pointer caching#51051
kimishpatel wants to merge 1 commit intopytorch:masterfrom
kimishpatel:export-D25984429

Conversation

@kimishpatel
Copy link
Copy Markdown
Contributor

Summary: Disable input pointer caching on ios. We are seeing some issues with this on some ios devices.

Test Plan:
FB:
Test this in of IG with BT effect.

Differential Revision: D25984429

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 25, 2021

💊 CI failures summary and remediations

As of commit 21de87f (more details on the Dr. CI page):


  • 3/3 failures possibly* introduced in this PR
    • 1/3 non-CircleCI failure(s)

2 failures not recognized by patterns:

Job Step Action
CircleCI pytorch_libtorch_linux_xenial_cuda11_1_cudnn8_py3_gcc7_build Build 🔁 rerun
CircleCI pytorch_linux_xenial_py3_clang5_asan_test2 Run tests 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D25984429

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2021

Codecov Report

Merging #51051 (bd0a142) into master (48b6b92) will increase coverage by 0.00%.
The diff coverage is 98.18%.

@@           Coverage Diff           @@
##           master   #51051   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1925     1926    +1     
  Lines      210008   210019   +11     
=======================================
+ Hits       169919   169947   +28     
+ Misses      40089    40072   -17     

Summary:
Pull Request resolved: pytorch#51051

Disable input pointer caching on ios. We are seeing some issues with this on some ios devices.

Test Plan:
FB:
Test this in of IG with BT effect.

Reviewed By: IvanKobzarev

Differential Revision: D25984429

fbshipit-source-id: 254bb996cc181612f6ebcbb0024b05e1c5816c15
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D25984429

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 6ef6621.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been reverted by ef472d5.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#51051

Disable input pointer caching on ios. We are seeing some issues with this on some ios devices.

Test Plan:
FB:
Test this in of IG with BT effect.

Reviewed By: IvanKobzarev, AshkanAliabadi

Differential Revision: D25984429

fbshipit-source-id: f6ceef606994b22de9cdd9752115b3481cd7bd96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants