Skip to content

Followup of kron PR#51045

Closed
zasdfgbnm wants to merge 3 commits intomasterfrom
kron2
Closed

Followup of kron PR#51045
zasdfgbnm wants to merge 3 commits intomasterfrom
kron2

Conversation

@zasdfgbnm
Copy link
Copy Markdown
Collaborator

Followup of #50927

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 25, 2021

💊 CI failures summary and remediations

As of commit 1a51373 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Comment thread aten/src/ATen/native/LinearAlgebra.cpp Outdated
mul_shape[2 * i + 1] = b_reshape[2 * i + 1];
}
resize_output(result, result_reshape);
auto result_mul = result.view(mul_shape);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsafe_view

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2021

Codecov Report

Merging #51045 (1a51373) into master (f7b339d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #51045   +/-   ##
=======================================
  Coverage   80.91%   80.92%           
=======================================
  Files        1926     1926           
  Lines      210014   210019    +5     
=======================================
+ Hits       169942   169949    +7     
+ Misses      40072    40070    -2     

Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zasdfgbnm!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ngimel merged this pull request in 16dd5ca.

@zasdfgbnm zasdfgbnm deleted the kron2 branch January 27, 2021 18:38
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Followup of pytorch#50927

Pull Request resolved: pytorch#51045

Reviewed By: mruberry

Differential Revision: D26089204

Pulled By: ngimel

fbshipit-source-id: 77291dd83fba32d6f80a8540910b112a1d85a892
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants