update HistogramObserver to be scriptable#51001
Merged
lyoka merged 4 commits intogh/lyoka/1/basefrom Jan 26, 2021
Merged
Conversation
fix tests in TestQuantizeJitOps [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 03da653 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
fix tests in TestQuantizeJitOps Differential Revision: [D26038759](https://our.internmc.facebook.com/intern/diff/D26038759) [ghstack-poisoned]
| loaded = torch.jit.load(buf) | ||
| self.assertTrue(torch.equal(obs.get_tensor_value()[0], loaded.get_tensor_value()[0])) | ||
|
|
||
| class TestHistogramObserver(QuantizationTestCase): |
Contributor
There was a problem hiding this comment.
Wondering if the tests in def test_save_load_state_dict_script(self) already cover this test.
Contributor
Author
There was a problem hiding this comment.
that test scripted the model but didn't save to file, and this problem happens at save step.
fix tests in TestQuantizeJitOps Differential Revision: [D26038759](https://our.internmc.facebook.com/intern/diff/D26038759) [ghstack-poisoned]
raghuramank100
approved these changes
Jan 26, 2021
lyoka
pushed a commit
to lyoka/pytorch
that referenced
this pull request
Jan 26, 2021
Summary: Pull Request resolved: pytorch#51001 fix tests in TestQuantizeJitOps Test Plan: Imported from OSS python test/test_quantization.py Reviewed By: raghuramank100 Differential Revision: D26038759 Pulled By: lyoka fbshipit-source-id: c38bbe81273654795451366fa72d76453954fad9
fix tests in TestQuantizeJitOps Differential Revision: [D26038759](https://our.internmc.facebook.com/intern/diff/D26038759) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/lyoka/1/base #51001 +/- ##
===================================================
- Coverage 80.91% 80.91% -0.01%
===================================================
Files 1926 1926
Lines 210291 210285 -6
===================================================
- Hits 170157 170148 -9
- Misses 40134 40137 +3 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 27, 2021
Summary: Pull Request resolved: #51081 Pull Request resolved: #51001 fix tests in TestQuantizeJitOps Test Plan: Imported from OSS python test/test_quantization.py Reviewed By: raghuramank100 Differential Revision: D26038759 Pulled By: lyoka fbshipit-source-id: 0977ba7b8b26a9f654f20f5c698a7a20ec078c35
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#51081 Pull Request resolved: pytorch#51001 fix tests in TestQuantizeJitOps Test Plan: Imported from OSS python test/test_quantization.py Reviewed By: raghuramank100 Differential Revision: D26038759 Pulled By: lyoka fbshipit-source-id: 0977ba7b8b26a9f654f20f5c698a7a20ec078c35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
fix tests in TestQuantizeJitOps
Differential Revision: D26038759