Conversation
💊 CI failures summary and remediationsAs of commit 666d19f (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
|
Thanks @henryiii for updating and merging pybind PR |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
a4b25c5 to
8f9e737
Compare
8f9e737 to
e34ff4e
Compare
|
FYI, pybind11 2.6.2 should be out tomorrow if you'd like an exact tagged version. (No changes from current master except the version number) |
|
(ResolutionCallback should return py::object rather than py:function
|
Codecov Report
@@ Coverage Diff @@
## master #50998 +/- ##
==========================================
- Coverage 80.91% 80.90% -0.01%
==========================================
Files 1925 1925
Lines 210008 210008
==========================================
- Hits 169919 169905 -14
- Misses 40089 40103 +14 |
Update pybind repo to include `gil_scoped_acquire::disarm()` methods In python_engine allocate scoped_acquire as unique_ptr and leak it if engine is finalizing for Python-3.9+
e34ff4e to
666d19f
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@henryiii thank you for the heads up. Will update to official 2.6.2 in the followup PR. |
Summary: Update pybind repo to include `gil_scoped_acquire::disarm()` methods In python_engine allocate scoped_acquire as unique_ptr and leak it if engine is finalizing for Python-3.9+ Fixes pytorch#50014 and pytorch#50893 Pull Request resolved: pytorch#50998 Reviewed By: ezyang Differential Revision: D26038314 Pulled By: malfet fbshipit-source-id: 035411e22825e8fdcf1348fed36da0bc33e16f60
Update pybind repo to include
gil_scoped_acquire::disarm()methodsIn python_engine allocate scoped_acquire as unique_ptr and leak it if engine is finalizing for Python-3.9+
Fixes #50014 and #50893