Skip to content

Skip test_lc_1d for ROCM#50964

Closed
arindamroy-eng wants to merge 1 commit intopytorch:masterfrom
arindamroy-eng:ROCM_Skip_test_lc_1d
Closed

Skip test_lc_1d for ROCM#50964
arindamroy-eng wants to merge 1 commit intopytorch:masterfrom
arindamroy-eng:ROCM_Skip_test_lc_1d

Conversation

@arindamroy-eng
Copy link
Copy Markdown
Contributor

@arindamroy-eng arindamroy-eng commented Jan 22, 2021

The test is flaky on ROCM when deadline is set to 1 second. This is affecting builds as it is failing randomly.
Disabling for now.

Signed-off-by: Arindam Roy rarindam@gmail.com

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 22, 2021

💊 CI failures summary and remediations

As of commit d6b1624 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

The test is flaky on ROCM when deadline
is set to 1 second. This is affecting builds
as it is failing randomly.
Disabling for now.

Signed-off-by: Arindam Roy <rarindam@gmail.com>
@arindamroy-eng
Copy link
Copy Markdown
Contributor Author

@jeffdaily

@jeffdaily jeffdaily added the module: rocm AMD GPU support for Pytorch label Jan 22, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2021

Codecov Report

Merging #50964 (d6b1624) into master (4bbff92) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #50964      +/-   ##
==========================================
- Coverage   80.99%   80.65%   -0.35%     
==========================================
  Files        1916     1916              
  Lines      209608   209608              
==========================================
- Hits       169780   169066     -714     
- Misses      39828    40542     +714     

@bdhirsh bdhirsh requested review from jspark1105 and xiaomengy and removed request for jspark1105 January 25, 2021 14:58
Copy link
Copy Markdown
Contributor

@xiaomengy xiaomengy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BIT-silence has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@BIT-silence merged this pull request in 09b8962.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
The test is flaky on ROCM when deadline is set to 1 second. This is affecting builds as it is failing randomly.
Disabling for now.

Signed-off-by: Arindam Roy <rarindam@gmail.com>

Pull Request resolved: pytorch#50964

Reviewed By: houseroad

Differential Revision: D26049370

Pulled By: BIT-silence

fbshipit-source-id: 22337590a8896ad75f1281e56fbbeae897f5c3b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants