[PyTorch Mobile] Add an overload for deserialize() that doesn't accept the extra_files map.#50932
Closed
dhruvbird wants to merge 3 commits intogh/dhruvbird/28/basefrom
Closed
[PyTorch Mobile] Add an overload for deserialize() that doesn't accept the extra_files map.#50932dhruvbird wants to merge 3 commits intogh/dhruvbird/28/basefrom
dhruvbird wants to merge 3 commits intogh/dhruvbird/28/basefrom
Conversation
…t the extra_files map. After the change to split `_load_for_mobile()` into multiple methods, one which takes in the `extra_files` map, and one which doesn't, we can change the implementation of the `deserialize()` method with different overloads as well. Suggested by @razy on D25968216. #accept2ship Differential Revision: [D26014084](https://our.internmc.facebook.com/intern/diff/D26014084/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 8e6cb59 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
…esn't accept the extra_files map." After the change to split `_load_for_mobile()` into multiple methods, one which takes in the `extra_files` map, and one which doesn't, we can change the implementation of the `deserialize()` method with different overloads as well. Suggested by @razy on D25968216. #accept2ship Differential Revision: [D26014084](https://our.internmc.facebook.com/intern/diff/D26014084/) [ghstack-poisoned]
…esn't accept the extra_files map." After the change to split `_load_for_mobile()` into multiple methods, one which takes in the `extra_files` map, and one which doesn't, we can change the implementation of the `deserialize()` method with different overloads as well. Suggested by @razy on D25968216. #accept2ship Differential Revision: [D26014084](https://our.internmc.facebook.com/intern/diff/D26014084/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Jan 22, 2021
…t the extra_files map. Pull Request resolved: #50932 After the change to split `_load_for_mobile()` into multiple methods, one which takes in the `extra_files` map, and one which doesn't, we can change the implementation of the `deserialize()` method with different overloads as well. Suggested by @razy on D25968216. #accept2ship ghstack-source-id: 120185089 Differential Revision: [D26014084](https://our.internmc.facebook.com/intern/diff/D26014084/)
Contributor
|
This pull request has been merged in ce0f335. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…t the extra_files map. (pytorch#50932) Summary: Pull Request resolved: pytorch#50932 After the change to split `_load_for_mobile()` into multiple methods, one which takes in the `extra_files` map, and one which doesn't, we can change the implementation of the `deserialize()` method with different overloads as well. Suggested by raziel on D25968216 (pytorch@0dc1a2e). ghstack-source-id: 120185089 Test Plan: Build/Sandcastle. Reviewed By: JacobSzwejbka Differential Revision: D26014084 fbshipit-source-id: 914142137346a6246def1acf38a3204dd4c4f52f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
After the change to split
_load_for_mobile()into multiple methods, one which takes in theextra_filesmap, and one which doesn't, we can change the implementation of thedeserialize()method with different overloads as well. Suggested by @razy on D25968216.#accept2ship
Differential Revision: D26014084