Skip to content

Add Gaussian NLL Loss#50886

Closed
nailimixaM wants to merge 1 commit intopytorch:masterfrom
nailimixaM:gnllloss
Closed

Add Gaussian NLL Loss#50886
nailimixaM wants to merge 1 commit intopytorch:masterfrom
nailimixaM:gnllloss

Conversation

@nailimixaM
Copy link
Copy Markdown

@nailimixaM nailimixaM commented Jan 21, 2021

Fixes #48520.

cc @albanD (This is a clean retry PR #49807)

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 21, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2204266 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

ci.pytorch.org: 2 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

albanD
albanD approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Could you just revert the tensorpipe submodule update please? (let me know if you want me to do it)

Will land when the submodule is fixed!

@nailimixaM
Copy link
Copy Markdown
Author

nailimixaM commented Jan 21, 2021

Looks great!
Could you just revert the tensorpipe submodule update please? (let me know if you want me to do it)

Will land when the submodule is fixed!

Done, fingers crossed this works!

@albanD
Copy link
Copy Markdown
Collaborator

albanD commented Jan 21, 2021

(rocm failures look unrelated)

facebook-github-bot
facebook-github-bot reviewed Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 21, 2021

Codecov Report

Merging #50886 (2204266) into master (480bb7d) will increase coverage by 0.00%.
The diff coverage is 84.21%.

@@           Coverage Diff           @@
##           master   #50886   +/-   ##
=======================================
  Coverage   81.01%   81.01%           
=======================================
  Files        1916     1916           
  Lines      209285   209323   +38     
=======================================
+ Hits       169562   169593   +31     
- Misses      39723    39730    +7

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 22, 2021

@albanD merged this pull request in 8eb90d4.

@almson
Copy link
Copy Markdown

almson commented Mar 13, 2021 •
edited
Loading

Please see #53964

Main points:

  • reduction 'none' is not implemented the way it is elsewhere
  • nn.functional.gaussian_nll_loss is missing in the documentation
  • full parameter is useless and not theoretically grounded.
  • var should not be clamped in a no_grad context. gradients should be masked by the clamping.

@nailimixaM
Copy link
Copy Markdown
Author

nailimixaM commented Mar 13, 2021

@almson Thanks for your points. I've addressed these in #53964.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Add Gaussian NLL Loss (pytorch#50886)
1833028 
Summary:
Fixes pytorch#48520.

cc albanD (This is a clean retry PR pytorch#49807)

Pull Request resolved: pytorch#50886

Reviewed By: ejguan

Differential Revision: D26007435

Pulled By: albanD

fbshipit-source-id: 88fe91b40dea6f72e093e6301f0f04fcc842d2f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gaussian NLL loss

5 participants

@nailimixaM @facebook-github-bot @albanD @almson @pytorchbot