Add alternative prettyprinting method to Graph#50878
Closed
ansley wants to merge 3 commits intogh/ansleyadelaide/35/basefrom
Closed
Add alternative prettyprinting method to Graph#50878ansley wants to merge 3 commits intogh/ansleyadelaide/35/basefrom
Graph#50878ansley wants to merge 3 commits intogh/ansleyadelaide/35/basefrom
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
jamesr66a
reviewed
Jan 21, 2021
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Couple things:
tabulateis not a PyTorch dependency and it's probably not worth it to add it for this one function- What benefit are folks getting from using print_IR rather than printing the
Graph? My original suggestion was to incorporate whatever benefit they're getting from print_IR into the graph printout
[ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/ansleyadelaide/35/base #50878 +/- ##
=============================================================
- Coverage 81.01% 80.70% -0.32%
=============================================================
Files 1916 1916
Lines 209285 209292 +7
=============================================================
- Hits 169562 168909 -653
- Misses 39723 40383 +660 |
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50878 Test Plan: Imported from OSS Reviewed By: SplitInfinity, eellison Differential Revision: D26009183 Pulled By: ansley fbshipit-source-id: 300913ea634d9a0e5b00deb831154ef126ad4180
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Graph#50878 Add alternative prettyprinting method toGraphDifferential Revision: D26009183