Hi @narain1!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Codecov Report

Merging #50866 (e6441c4) into master (c945a5b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #50866      +/-   ##
==========================================
- Coverage   81.02%   81.01%   -0.01%     
==========================================
  Files        1916     1916              
  Lines      209287   209287              
==========================================
- Hits       169568   169558      -10     
- Misses      39719    39729      +10     

will these changes also reflect on the XLA branch?

This is the same code used by xla yes.
Not sure what is the release cycle on the xla package though.

Also the changes you pushed are unrelated right? I will remove them from the PR before landing.

Yeah the last commit was a pr for a different issue I'm still figuring out to remove it😑

You can either:

• do a revert commit and push it in this branch. So that the final diff is correct. And the commit history is removed when landing anyway so we don't care for the extra commits
• locally remove the commit by checking out the previous commit, then make that the new branch and force push it here.

No worries.
I landed a version without the last commit ;)