Add note about TCP init in RPC tests to contributing doc.#50861
Closed
rohan-varma wants to merge 3 commits intopytorch:masterfrom
Closed
Add note about TCP init in RPC tests to contributing doc.#50861rohan-varma wants to merge 3 commits intopytorch:masterfrom
rohan-varma wants to merge 3 commits intopytorch:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50861 +/- ##
==========================================
+ Coverage 75.65% 81.01% +5.36%
==========================================
Files 1916 1916
Lines 209287 209287
==========================================
+ Hits 158343 169561 +11218
+ Misses 50944 39726 -11218 |
wayi1
approved these changes
Jan 21, 2021
Contributor
|
Thanks for the documentation! |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@rohan-varma has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@rohan-varma merged this pull request in 7e10fbf. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
) Summary: We added this option in pytorch#48248, but it would be good to document it somewhere as well, hence adding it to this contributing doc. Pull Request resolved: pytorch#50861 Reviewed By: mrshenli Differential Revision: D26014505 Pulled By: rohan-varma fbshipit-source-id: c1321679f01dd52038131ff571362ad36884510a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added this option in #48248, but it would be good to document it somewhere as well, hence adding it to this contributing doc.