Skip to content

[TensorExpr] Add LoopNest::simplify.#50850

Closed
ZolotukhinM wants to merge 1 commit intogh/ZolotukhinM/394/basefrom
gh/ZolotukhinM/394/head
Closed

[TensorExpr] Add LoopNest::simplify.#50850
ZolotukhinM wants to merge 1 commit intogh/ZolotukhinM/394/basefrom
gh/ZolotukhinM/394/head

Conversation

@ZolotukhinM
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM commented Jan 20, 2021

Stack from ghstack:

Differential Revision: D25985085

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 20, 2021
ZolotukhinM pushed a commit that referenced this pull request Jan 20, 2021
ghstack-source-id: a24a0a4
Pull Request resolved: #50850
Copy link
Copy Markdown
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If I'm understanding this right, this is just a wrapper around te.simplify(loopnest.root_stmt())?

@ZolotukhinM
Copy link
Copy Markdown
Author

If I'm understanding this right, this is just a wrapper around te.simplify(loopnest.root_stmt())?

It also updates the root_stmt of the loopnest - that's the main reason I added it. This place is a bit yucky tbh - i.e. we could do something with stmt and then root_stmt becomes stale. In future we need to clean this up, but for now we will have this workaround :)

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ZolotukhinM merged this pull request in 5f07b53.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/394/head branch January 26, 2021 15:21
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#50850

Test Plan: Imported from OSS

Reviewed By: Chillee

Differential Revision: D25985085

Pulled By: ZolotukhinM

fbshipit-source-id: e51709423c2c12b37b449a9d7bb22be04cda7ef1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants