[PyTorch] Eliminate static default_extra_files_mobile from header import.h#50832
Closed
dhruvbird wants to merge 4 commits intogh/dhruvbird/27/basefrom
Closed
[PyTorch] Eliminate static default_extra_files_mobile from header import.h#50832dhruvbird wants to merge 4 commits intogh/dhruvbird/27/basefrom
dhruvbird wants to merge 4 commits intogh/dhruvbird/27/basefrom
Conversation
…ort.h Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Jan 20, 2021
…ort.h Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/) ghstack-source-id: 120058925 Pull Request resolved: #50832
… header import.h" Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Jan 20, 2021
…ort.h Pull Request resolved: #50832 Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. ghstack-source-id: 120083081 Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/)
… header import.h" Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Jan 21, 2021
…ort.h Pull Request resolved: #50832 Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. ghstack-source-id: 120127081 Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/)
… header import.h" Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/) [ghstack-poisoned]
dhruvbird
added a commit
that referenced
this pull request
Jan 22, 2021
…ort.h Pull Request resolved: #50832 Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. ghstack-source-id: 120184012 Differential Revision: [D25979986](https://our.internmc.facebook.com/intern/diff/D25979986/)
Contributor
|
This pull request has been merged in 156da22. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ort.h (pytorch#50832) Summary: Pull Request resolved: pytorch#50832 Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase. ghstack-source-id: 120184012 Test Plan: Sandcastle + Build Reviewed By: raziel, iseeyuan Differential Revision: D25979986 fbshipit-source-id: 7708f4f6a50cb16d7a23651e5655144d277d0a4f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Please see the previous diff in this stack for the motivation to do so. This makes the same change but for the non-mobile codebase.
Differential Revision: D25979986