Add type annotations to torch.overrides#50824
Closed
guilhermeleobas wants to merge 22 commits intopytorch:masterfrom
guilhermeleobas:override
Closed
Add type annotations to torch.overrides#50824guilhermeleobas wants to merge 22 commits intopytorch:masterfrom guilhermeleobas:override
guilhermeleobas wants to merge 22 commits intopytorch:masterfrom
guilhermeleobas:override
Conversation
hameerabbasi
requested changes
Jan 21, 2021
Collaborator
hameerabbasi
left a comment
There was a problem hiding this comment.
One minor comment.
Co-authored-by: Hameer Abbasi <einstein.edison@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #50824 +/- ##
==========================================
- Coverage 80.66% 80.65% -0.01%
==========================================
Files 1913 1913
Lines 208058 208059 +1
==========================================
- Hits 167833 167819 -14
- Misses 40225 40240 +15 |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This is a follow up PR of pytorch#48493. Fixes pytorch#48492 Pull Request resolved: pytorch#50824 Reviewed By: bdhirsh Differential Revision: D26050736 Pulled By: ezyang fbshipit-source-id: 049605fd271cff28c8b6e300c163e9df3b3ea23b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR of #48493.
Fixes #48492