Remove use_c10_dispatcher: full lines added in the last couple days#50769
Closed
smessmer wants to merge 5 commits intogh/smessmer/295/basefrom
Closed
Remove use_c10_dispatcher: full lines added in the last couple days#50769smessmer wants to merge 5 commits intogh/smessmer/295/basefrom
use_c10_dispatcher: full lines added in the last couple days#50769smessmer wants to merge 5 commits intogh/smessmer/295/basefrom
Conversation
There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/) [ghstack-poisoned]
…couple days" There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/) [ghstack-poisoned]
bhosmer
approved these changes
Jan 19, 2021
…couple days" There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/) [ghstack-poisoned]
…couple days" There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 20, 2021
Pull Request resolved: #50769 There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. ghstack-source-id: 120018439 Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/)
…couple days" There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Jan 21, 2021
Pull Request resolved: #50769 There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. ghstack-source-id: 120133715 Differential Revision: [D25961316](https://our.internmc.facebook.com/intern/diff/D25961316/)
Codecov Report
@@ Coverage Diff @@
## gh/smessmer/295/base #50769 +/- ##
========================================================
- Coverage 81.01% 81.01% -0.01%
========================================================
Files 1916 1916
Lines 209285 209285
========================================================
- Hits 169562 169560 -2
- Misses 39723 39725 +2 |
Contributor
|
This pull request has been merged in d462109. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…pytorch#50769) Summary: Pull Request resolved: pytorch#50769 There were a couple new of these lines added in the last couple of days but they're not necessary anymore. This PR removes them and also adds an assertion to make sure we don't add any more. ghstack-source-id: 120133715 Test Plan: waitforsandcastle Reviewed By: bhosmer Differential Revision: D25961316 fbshipit-source-id: e2befc5b6215b42decb2acedcacfb50734857e2f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
use_c10_dispatcher: fulllines added in the last couple days #50769 Removeuse_c10_dispatcher: fulllines added in the last couple daysThere were a couple new of these lines added in the last couple of days but they're not necessary anymore.
This PR removes them and also adds an assertion to make sure we don't add any more.
Differential Revision: D25961316