Skip to content

Revert "Stable sort for CPU (#50052)"#50752

Closed
glaringlee wants to merge 1 commit intopytorch:masterfrom
glaringlee:master
Closed

Revert "Stable sort for CPU (#50052)"#50752
glaringlee wants to merge 1 commit intopytorch:masterfrom
glaringlee:master

Conversation

@glaringlee
Copy link
Copy Markdown
Contributor

@glaringlee glaringlee commented Jan 19, 2021 •
edited
Loading

This reverts commit c99f356.

facebook-github-bot
facebook-github-bot reviewed Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@glaringlee
Copy link
Copy Markdown
Contributor Author

glaringlee commented Jan 19, 2021

@JackCaoG
Hi, I am going to revert this change since it breaks fb internal model integration tests. Can you help to revert the xla change on your side if needed. We will land this code later.

@glaringlee glaringlee requested a review from zou3519 January 19, 2021 19:33
@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Jan 19, 2021

@JackCaoG
Hi, I am going to revert this change since it breaks fb internal model integration tests. Can you help to revert the xla change on your side if needed. We will land this code later.

yea, I will revert too

@JackCaoG JackCaoG mentioned this pull request Jan 19, 2021
Merged
@glaringlee
Copy link
Copy Markdown
Contributor Author

glaringlee commented Jan 19, 2021

@nikitaved I probably need to revert this code today since it breaks our fb internal tests. I will try to put a fix, but if it doesn't work, I will revert the entire stable sort code

@glaringlee
Copy link
Copy Markdown
Contributor Author

glaringlee commented Jan 19, 2021

@JackCaoG
Hi, I am going to revert this change since it breaks fb internal model integration tests. Can you help to revert the xla change on your side if needed. We will land this code later.

yea, I will revert too

I will try to fix it in next 2 hours, will let you know.

@glaringlee
Copy link
Copy Markdown
Contributor Author

glaringlee commented Jan 19, 2021

@JackCaoG
We start to revert this. Please revert the xla change once this pr is closed.
@nikitaved I am working on a fix, can you reopen a PR so we can add the fix in once I verify the fix works for all the cases? Thanks a lot.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 20, 2021

@glaringlee merged this pull request in 7526e38.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
Revert "Stable sort for CPU (pytorch#50052)" (pytorch#50752)
0741489 
Summary:
This reverts commit 4d82d19.

Pull Request resolved: pytorch#50752

Reviewed By: zou3519

Differential Revision: D25958146

Pulled By: glaringlee

fbshipit-source-id: f4068d038f9bd337bac8b673eaeb46a4646f6c77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zou3519 zou3519 zou3519 approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@glaringlee @JackCaoG @facebook-github-bot @zou3519