Skip to content

[pytorch] fix ConstRefCType usage in codegen/api/native.py#50742

Closed
ljk53 wants to merge 1 commit intogh/ljk53/199/basefrom
gh/ljk53/199/head
Closed

[pytorch] fix ConstRefCType usage in codegen/api/native.py#50742
ljk53 wants to merge 1 commit intogh/ljk53/199/basefrom
gh/ljk53/199/head

Conversation

@ljk53
Copy link
Copy Markdown
Contributor

@ljk53 ljk53 commented Jan 19, 2021

Stack from ghstack:

Summary:
Fixed the other usage of BaseCType('const ...&) on #49138.

Checked byte-for-byte compatibility of the codegen output.

Differential Revision: D25955565

Summary:
Fixed the other usage of `BaseCType('const ...&)` on #49138.

Checked byte-for-byte compatibility of the codegen output.

[ghstack-poisoned]
ljk53 added a commit that referenced this pull request Jan 19, 2021
Summary:
Fixed the other usage of `BaseCType('const ...&)` on #49138.

Checked byte-for-byte compatibility of the codegen output.

ghstack-source-id: 1d5a838
Pull Request resolved: #50742
@ljk53 ljk53 requested review from ezyang and smessmer January 19, 2021 17:25
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2021

Codecov Report

Merging #50742 (1bba3ca) into gh/ljk53/199/base (1154a85) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           gh/ljk53/199/base   #50742      +/-   ##
=====================================================
- Coverage              80.65%   80.65%   -0.01%     
=====================================================
  Files                   1913     1913              
  Lines                 208139   208139              
=====================================================
- Hits                  167872   167871       -1     
- Misses                 40267    40268       +1     

Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ljk53 merged this pull request in 24fd843.

@facebook-github-bot facebook-github-bot deleted the gh/ljk53/199/head branch January 24, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants