Complex autograd support for torch.{baddbmm, addbmm, addmm, addmv}#50632
Closed
anjali411 wants to merge 3 commits intogh/anjali411/84/basefrom
Closed
Complex autograd support for torch.{baddbmm, addbmm, addmm, addmv}#50632anjali411 wants to merge 3 commits intogh/anjali411/84/basefrom
anjali411 wants to merge 3 commits intogh/anjali411/84/basefrom
Conversation
[ghstack-poisoned]
…, addmv, addr}" I'll port the following method tests in follow-up PRs: `'baddbmm', 'addbmm', 'addmv', 'addr'` After the tests are ported to method_tests, it would also be much easier to add tests with complex alpha and beta values. [ghstack-poisoned]
…, addmv, addr}" I'll port the following method tests in follow-up PRs: `'baddbmm', 'addbmm', 'addmv', 'addr'` After the tests are ported to method_tests, it would also be much easier to add tests with complex alpha and beta values. [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/anjali411/84/base #50632 +/- ##
========================================================
- Coverage 80.66% 80.65% -0.01%
========================================================
Files 1912 1912
Lines 208082 208086 +4
========================================================
- Hits 167845 167841 -4
- Misses 40237 40245 +8 |
mruberry
reviewed
Jan 18, 2021
Collaborator
That'd be great. The addr OpInfo looks good (see comments on PR).
This makes sense. Let's just skip those tests for now with a pointer to a new issue about how those tests don't work with broadcasting. |
Contributor
|
@anjali411 merged this pull request in 227acc2. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#50632) Summary: Pull Request resolved: pytorch#50632 I'll port the following method tests in follow-up PRs: `'baddbmm', 'addbmm', 'addmv', 'addr'` After the tests are ported to OpInfo based tests, it would also be much easier to add tests with complex alpha and beta values. Edit- it seems like it's hard to port the broadcasting variant tests because one ends up skipping `test_inplace_grad` and `test_variant_consistency_eager` even for the case when inputs are not required to be broadcasted. Test Plan: Imported from OSS Reviewed By: navahgar Differential Revision: D25947471 Pulled By: anjali411 fbshipit-source-id: 9faa7f1fd55a1269bad282adac2b39d19bfa4591
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
I'll port the following method tests in follow-up PRs:
'baddbmm', 'addbmm', 'addmv', 'addr'After the tests are ported to OpInfo based tests, it would also be much easier to add tests with complex alpha and beta values.
Edit- it seems like it's hard to port the broadcasting variant tests because one ends up skipping
test_inplace_gradandtest_variant_consistency_eagereven for the case when inputs are not required to be broadcasted.Differential Revision: D25947471