Create a DDPLoggingData and expose it to python interface#50622
Closed
zhaojuanmao wants to merge 5 commits intogh/zhaojuanmao/55/basefrom
Closed
Create a DDPLoggingData and expose it to python interface#50622zhaojuanmao wants to merge 5 commits intogh/zhaojuanmao/55/basefrom
zhaojuanmao wants to merge 5 commits intogh/zhaojuanmao/55/basefrom
Conversation
1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 15, 2021
1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/) ghstack-source-id: 119889265 Pull Request resolved: #50622
rohan-varma
reviewed
Jan 16, 2021
rohan-varma
reviewed
Jan 16, 2021
wayi1
reviewed
Jan 20, 2021
wayi1
reviewed
Jan 20, 2021
wayi1
reviewed
Jan 20, 2021
1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/) [ghstack-poisoned]
wayi1
approved these changes
Jan 22, 2021
1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 22, 2021
Pull Request resolved: #50622 1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc ghstack-source-id: 120230992 Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/)
1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 23, 2021
Pull Request resolved: #50622 1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc ghstack-source-id: 120246769 Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/)
1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/) [ghstack-poisoned]
zhaojuanmao
added a commit
that referenced
this pull request
Jan 24, 2021
Pull Request resolved: #50622 1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc ghstack-source-id: 120275870 Differential Revision: [D25930527](https://our.internmc.facebook.com/intern/diff/D25930527/)
Codecov Report
@@ Coverage Diff @@
## gh/zhaojuanmao/55/base #50622 +/- ##
==========================================================
- Coverage 81.00% 80.99% -0.01%
==========================================================
Files 1916 1916
Lines 209532 209579 +47
==========================================================
+ Hits 169728 169750 +22
- Misses 39804 39829 +25 |
Contributor
|
This pull request has been merged in 250c711. |
rohan-varma
reviewed
Jan 28, 2021
| py::arg("comm_hook_type")); | ||
| py::arg("comm_hook_type")) | ||
| .def( | ||
| "_set_construction_logging_data", |
Contributor
There was a problem hiding this comment.
Nit, and a late comment: Is there any reason why we're doing this with a level of indirection rather than calling the method directly on the reducer?
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
) Summary: Pull Request resolved: pytorch#50622 1. Define a DDPLoggingData struct that is the placeholder for all the ddp related logging fields 2. Put the DDPLoggingData struct in the C10 directory so that it can be easily imported by c10 and torch files 3. Expose get_ddp_logging_data() method in python so that users can get the logging data and dump in their applications 4. Unit test tested the logging data can be set and got as expected 5. Follow up will add more logging fields such as perf stats, internal states, env variables and etc ghstack-source-id: 120275870 Test Plan: unit tests Reviewed By: SciPioneer Differential Revision: D25930527 fbshipit-source-id: 290c200161019c58e28eed9a5a2a7a8153113f99
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25930527