Document example of Proxy use#50583
Closed
ansley wants to merge 5 commits intogh/ansleyadelaide/33/basefrom
Closed
Document example of Proxy use#50583ansley wants to merge 5 commits intogh/ansleyadelaide/33/basefrom
ansley wants to merge 5 commits intogh/ansleyadelaide/33/basefrom
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
jamesr66a
reviewed
Jan 15, 2021
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Looks good, though I think this emphasizes a "boundary case" I guess I would call it, where you're tracing an entire function. It might be good to show also show using Proxy's to inline a given function into another function, or to show using Proxies within some metaprogramming code to emit operations (i.e. not just tracing through straightline code)
[ghstack-poisoned]
jamesr66a
approved these changes
Jan 22, 2021
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Looks good, just some small stuff then we should be good to go
[ghstack-poisoned]
Differential Revision: [D26010501](https://our.internmc.facebook.com/intern/diff/D26010501) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50583 Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26010501 Pulled By: ansley fbshipit-source-id: 947121af7e57c16c96f849fbbb3fa83e97d003b2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D26010501