Fix topk work size computation#5053
Merged
soumith merged 2 commits intopytorch:masterfrom Feb 6, 2018
Merged
Conversation
soumith
pushed a commit
that referenced
this pull request
Feb 7, 2018
* fix grid computation for topk kernel * backslash alignment, no change in code
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
* fix grid computation for topk kernel * backslash alignment, no change in code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
collapseDimsactually collapses stuff, theinputSlicesis multiplied by undefined value (which is what was previously in the.sizesarray).fix #4490 and #4513