Skip to content

[TEST][DO NOT MERGE] ci-all cusolver-svd#50516

Closed
xwang233 wants to merge 60 commits intomasterfrom
ci-all/cusolver-svd
Closed

[TEST][DO NOT MERGE] ci-all cusolver-svd#50516
xwang233 wants to merge 60 commits intomasterfrom
ci-all/cusolver-svd

Conversation

@xwang233
Copy link
Copy Markdown
Collaborator

See #48436

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 14, 2021

💊 CI failures summary and remediations

As of commit 3075adc (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@mrshenli mrshenli added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 15, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@heitorschueroff merged this pull request in 186c3da.

@github-actions github-actions Bot deleted the ci-all/cusolver-svd branch February 10, 2024 01:54
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
…torch#48436)

Summary:
This PR adds cusolver `gesvdj` and `gesvdjBatched` to the backend of `torch.svd`.

I've tested the performance using cuda 11.1 on 2070, V100, and A100. The cusolver gesvdj and gesvdjBatched performances are better than magma in all square matrix cases. So cusolver backend will replace magma backend when available.

When both matrix dimensions are no greater than 32, `gesvdjBatched` is used. Otherwise, `gesvdj` is used.

Detailed benchmark is available at https://github.com/xwang233/code-snippet/tree/master/svd.

Some relevant code and discussions
- https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/kernels/linalg/svd_op_gpu.cu.cc
- https://github.com/google/jax/blob/master/jaxlib/cusolver.cc
- cupy/cupy#3174
- tensorflow/tensorflow#13603
- https://www.nvidia.com/en-us/on-demand/session/gtcsiliconvalley2019-s9226/

See also pytorch#42666 pytorch#47953

Close pytorch#50516

Pull Request resolved: pytorch#48436

Reviewed By: ejguan

Differential Revision: D25977046

Pulled By: heitorschueroff

fbshipit-source-id: c27e705cd29b6fd7c8ac674c1f9f490fa26ee1bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants