OpInfo: Add DecorateInfo class similar to SkipInfo for decorators#50501
Closed
peterbell10 wants to merge 2 commits intopytorch:masterfrom
Closed
OpInfo: Add DecorateInfo class similar to SkipInfo for decorators#50501peterbell10 wants to merge 2 commits intopytorch:masterfrom
peterbell10 wants to merge 2 commits intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit e09b14a (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
4b7c3ac to
ffa3eaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #50501 +/- ##
==========================================
- Coverage 80.99% 80.65% -0.35%
==========================================
Files 1916 1913 -3
Lines 209552 208123 -1429
==========================================
- Hits 169736 167861 -1875
- Misses 39816 40262 +446 |
mruberry
reviewed
Jan 19, 2021
Collaborator
There was a problem hiding this comment.
Thank you for fixing this.
mruberry
approved these changes
Jan 19, 2021
Collaborator
mruberry
left a comment
There was a problem hiding this comment.
This is a smart improvement, thanks @peterbell10!
The test failure is unrelated but this does need a rebase, though. Just ping me when it's ready.
ffa3eaf to
71d2ac0
Compare
71d2ac0 to
6a77ecf
Compare
Collaborator
Author
|
@mruberry rebased and tests are all passing. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…torch#50501) Summary: Follow up to pytorch#50435 I have confirmed this works by running ``` pytest test_ops.py -k test_fn_gradgrad_fft` ``` with normally and with `PYTORCH_TEST_WITH_SLOW=1 PYTORCH_TEST_SKIP_FAST=1`. In the first case all tests are skipped, in the second they all run as they should. Pull Request resolved: pytorch#50501 Reviewed By: ezyang Differential Revision: D25956416 Pulled By: mruberry fbshipit-source-id: c896a8cec5f19b8ffb9b168835f3743b6986dad7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #50435
I have confirmed this works by running
with normally and with
PYTORCH_TEST_WITH_SLOW=1 PYTORCH_TEST_SKIP_FAST=1. In the first case all tests are skipped, in the second they all run as they should.