Enable ROCM Skipped tests in test_ops.py#50500
Enable ROCM Skipped tests in test_ops.py#50500arindamroy-eng wants to merge 3 commits intopytorch:masterfrom arindamroy-eng:Enable_ROCM_Skipped_Tests
Conversation
Removed @skipCUDAIfRocm to re-enable tests for ROCM platform. Initially, Only 4799 cases were being run. Out of those, 882 cases were being skipped. After removing @skipCUDAIfRocm from two places in test_ops.py, now more than 8000 cases are being executed, out of which only 282 cases are bing skipped, which are FFT related tests. Signed-off-by: Arindam Roy <rarindam@gmail.com>
|
Hi @arindamroy-eng! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
💊 CI failures summary and remediationsAs of commit e40d311 (more details on the Dr. CI page):
ci.pytorch.org: 2 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Removed skipCUDAIfRocm from test_ops.py. Signed-off-by: Arindam Roy <rarindam@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #50500 +/- ##
==========================================
- Coverage 80.72% 80.56% -0.16%
==========================================
Files 1909 1909
Lines 207041 207041
==========================================
- Hits 167125 166812 -313
- Misses 39916 40229 +313 |
Tests were failing for skipCUDAIfRocm for unsupported dtypes tests. Hence adding the tag back to them. skipCUDAIfRocm is remains removed from supported dtypes. Signed-off-by: Arindam Roy <rarindam@gmail.com>
mrshenli
left a comment
There was a problem hiding this comment.
Tests are green. I am landing this PR.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary:
Removed skipCUDAIfRocm to re-enable tests for
ROCM platform.
Initially, Only 4799 cases were being run.
Out of those, 882 cases were being skipped.
After removing skipCUDAIfRocm from two places
in test_ops.py, now more than 8000 cases are
being executed, out of which only 282 cases
are bing skipped, which are FFT related tests.
Signed-off-by: Arindam Roy <rarindam@gmail.com>
Fixes #{issue number}
Pull Request resolved: pytorch#50500
Reviewed By: albanD
Differential Revision: D25920303
Pulled By: mrshenli
fbshipit-source-id: b2d17b7e2d1de4f9fdd6f1660fb4cad5841edaa0
Removed @skipCUDAIfRocm to re-enable tests for
ROCM platform.
Initially, Only 4799 cases were being run.
Out of those, 882 cases were being skipped.
After removing @skipCUDAIfRocm from two places
in test_ops.py, now more than 8000 cases are
being executed, out of which only 282 cases
are bing skipped, which are FFT related tests.
Signed-off-by: Arindam Roy rarindam@gmail.com
Fixes #{issue number}