[quant] Factoring out the list of no_observers#50459
Closed
z-a-f wants to merge 12 commits intogh/z-a-f/99/basefrom
Closed
[quant] Factoring out the list of no_observers#50459z-a-f wants to merge 12 commits intogh/z-a-f/99/basefrom
z-a-f wants to merge 12 commits intogh/z-a-f/99/basefrom
Conversation
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 31e2a15 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jerryzh168
approved these changes
Jan 26, 2021
Contributor
jerryzh168
left a comment
There was a problem hiding this comment.
please address lint error as well
Contributor
|
also looks like the CI is failed |
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. [ghstack-poisoned]
added 8 commits
January 27, 2021 13:47
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. Differential Revision: [D26092531](https://our.internmc.facebook.com/intern/diff/D26092531) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/z-a-f/99/base #50459 +/- ##
====================================================
- Coverage 80.63% 80.63% -0.01%
====================================================
Files 1960 1960
Lines 215108 215110 +2
====================================================
+ Hits 173453 173454 +1
- Misses 41655 41656 +1 |
Contributor
|
This pull request has been merged in a07530e. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
Summary: Pull Request resolved: pytorch#50459 Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. (Note: this ignores all push blocking failures!) Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D26092531 fbshipit-source-id: 1f89daf3a13ef31bc4e9058c3443559c65a05812
jasperzhong
pushed a commit
to jasperzhong/swift
that referenced
this pull request
Nov 25, 2021
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. ghstack-source-id: 8a5cf0b Pull Request resolved: pytorch/pytorch#50459
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50459 Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function. Test is not required, as it is covered by the unittests for those modules. (Note: this ignores all push blocking failures!) Test Plan: Imported from OSS Reviewed By: vkuzo Differential Revision: D26092531 fbshipit-source-id: 1f89daf3a13ef31bc4e9058c3443559c65a05812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some of the custom modules cannot have the observers be inserted automatically. This PR factors out that list into a separate function.
Test is not required, as it is covered by the unittests for those modules.
Differential Revision: D26092531