Use quiet_NaN() in calc_digamma, not NAN#50412
Closed
xuhdev wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
This not only specifies the data types of these NaNs, but also indicate that the function isn't signaling anything unusual.
Contributor
💊 CI failures summary and remediationsAs of commit ad60ff2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
kshitij12345
approved these changes
Jan 12, 2021
Collaborator
kshitij12345
left a comment
There was a problem hiding this comment.
LGTM! Better to be explicit! Thanks for the catch!
Codecov Report
@@ Coverage Diff @@
## master #50412 +/- ##
=======================================
Coverage 80.69% 80.70%
=======================================
Files 1905 1905
Lines 206789 206789
=======================================
+ Hits 166872 166879 +7
+ Misses 39917 39910 -7 |
Collaborator
Author
|
@pytorchbot merge this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: This not only specifies the data types of these NaNs, but also indicate that the function isn't signaling anything unusual. Pull Request resolved: pytorch#50412 Reviewed By: mrshenli Differential Revision: D25899828 Pulled By: ezyang fbshipit-source-id: a8ded10954ad08cba3098aa473c6b77f2e03dc93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This not only specifies the data types of these NaNs, but also indicate
that the function isn't signaling anything unusual.