Skip to content

Introduced operator variant to OpInfo#50370

Closed
vfdev-5 wants to merge 1 commit intopytorch:masterfrom
Quansight:add-operator-variant-opinfo
Closed

Introduced operator variant to OpInfo#50370
vfdev-5 wants to merge 1 commit intopytorch:masterfrom
Quansight:add-operator-variant-opinfo

Conversation

@vfdev-5
Copy link
Copy Markdown
Contributor

@vfdev-5 vfdev-5 commented Jan 11, 2021

Introduced operator variant to OpInfo

Context: Split of #49158

cc @mruberry

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 11, 2021

💊 CI failures summary and remediations

As of commit d68b30f (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2021

Codecov Report

Merging #50370 (d68b30f) into master (9d8bd21) will decrease coverage by 0.09%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #50370      +/-   ##
==========================================
- Coverage   80.70%   80.61%   -0.10%     
==========================================
  Files        1904     1904              
  Lines      206596   206600       +4     
==========================================
- Hits       166742   166552     -190     
- Misses      39854    40048     +194     

@zhangguanheng66 zhangguanheng66 added module: testing Issues related to the torch.testing module (not tests) triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 11, 2021
Copy link
Copy Markdown
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

We actually some tests using operators today in test_binary_ufunc.py. When that test suite is updated we should be sure to migrate their operator testing, too.

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@mruberry merged this pull request in eae1b40.

@vfdev-5 vfdev-5 deleted the add-operator-variant-opinfo branch January 19, 2021 17:14
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Introduced operator variant to OpInfo

Context: Split of pytorch#49158

cc mruberry

Pull Request resolved: pytorch#50370

Reviewed By: mrshenli

Differential Revision: D25897821

Pulled By: mruberry

fbshipit-source-id: 4387ea10607dbd7209842b685f1794bcb31f434e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: testing Issues related to the torch.testing module (not tests) open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants