Skip to content

[vmap] Add batching rules for comparisons ops#50364

Closed
RockingJavaBean wants to merge 1 commit intopytorch:masterfrom
RockingJavaBean:batched_comparison_ops
Closed

[vmap] Add batching rules for comparisons ops#50364
RockingJavaBean wants to merge 1 commit intopytorch:masterfrom
RockingJavaBean:batched_comparison_ops

Conversation

@RockingJavaBean
Copy link
Copy Markdown
Contributor

Related to #49562

This PR adds batching rules for the below comparison ops.

  • torch.eq
  • torch.gt
  • torch.ge
  • torch.le
  • torch.lt
  • torch.ne

- torch.eq
- torch.gt
- torch.ge
- torch.le
- torch.lt
- torch.ne
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 11, 2021

💊 CI failures summary and remediations

As of commit 16fd139 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 3 times.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2021

Codecov Report

Merging #50364 (16fd139) into master (9d8bd21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #50364   +/-   ##
=======================================
  Coverage   80.70%   80.71%           
=======================================
  Files        1904     1904           
  Lines      206596   206606   +10     
=======================================
+ Hits       166742   166754   +12     
+ Misses      39854    39852    -2     

@zhangguanheng66 zhangguanheng66 added module: internals Related to internal abstractions in c10 and ATen triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Jan 11, 2021
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in 5cdc32b.

@RockingJavaBean RockingJavaBean deleted the batched_comparison_ops branch January 13, 2021 01:05
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Related to pytorch#49562

This PR adds batching rules for the below comparison ops.
- torch.eq
- torch.gt
- torch.ge
- torch.le
- torch.lt
- torch.ne

Pull Request resolved: pytorch#50364

Reviewed By: anjali411

Differential Revision: D25885359

Pulled By: zou3519

fbshipit-source-id: 58874f24f8d525d8fac9062186b1c9970618ff55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged module: internals Related to internal abstractions in c10 and ATen open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants