DOC, BLD: make the python docs build failures print a nicer message#50356
Closed
mattip wants to merge 1 commit intopytorch:masterfrom
Closed
DOC, BLD: make the python docs build failures print a nicer message#50356mattip wants to merge 1 commit intopytorch:masterfrom
mattip wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 7cfc730 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #50356 +/- ##
==========================================
- Coverage 80.68% 80.68% -0.01%
==========================================
Files 1904 1904
Lines 206562 206562
==========================================
- Hits 166674 166668 -6
- Misses 39888 39894 +6 |
brianjo
approved these changes
Jan 11, 2021
ranman
approved these changes
Jan 21, 2021
|
gentle ping |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@brianjo has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#50356) Summary: Fixes pytorch#50330 - Encapsulate the `make html` call and capture the stdout/stderr with a `tee` command - If the buld fails, print out the `WARNING:` lines of the build log and finish up with a message I tried it out on my branch, but did not write a test. Pull Request resolved: pytorch#50356 Reviewed By: ezyang Differential Revision: D26101762 Pulled By: brianjo fbshipit-source-id: ba2b704d3244ef5139ca9026c5250537bf45734f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50330
make htmlcall and capture the stdout/stderr with ateecommandWARNING:lines of the build log and finish up with a messageI tried it out on my branch, but did not write a test.