Skip to content

[PyTorch] Remove unnecessary dispatcher.h include in builtin_function.h#50314

Closed
swolchok wants to merge 2 commits intogh/swolchok/74/basefrom
gh/swolchok/74/head
Closed

[PyTorch] Remove unnecessary dispatcher.h include in builtin_function.h#50314
swolchok wants to merge 2 commits intogh/swolchok/74/basefrom
gh/swolchok/74/head

Conversation

@swolchok
Copy link
Copy Markdown
Contributor

@swolchok swolchok commented Jan 9, 2021

Stack from ghstack:

It's unused.

Differential Revision: D25858900

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 9, 2021

💊 CI failures summary and remediations

As of commit 7578845 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

…in_function.h"

It's unused.

Differential Revision: [D25858900](https://our.internmc.facebook.com/intern/diff/D25858900/)

[ghstack-poisoned]
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 14, 2021

Codecov Report

Merging #50314 (7578845) into gh/swolchok/74/base (deba3bd) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##           gh/swolchok/74/base   #50314      +/-   ##
=======================================================
- Coverage                80.73%   80.73%   -0.01%     
=======================================================
  Files                     1910     1910              
  Lines                   207182   207182              
=======================================================
- Hits                    167270   167263       -7     
- Misses                   39912    39919       +7     

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in 687f6a5.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/74/head branch January 19, 2021 15:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
….h (pytorch#50314)

Summary:
Pull Request resolved: pytorch#50314

It's unused.
ghstack-source-id: 119798800

Test Plan: CI

Reviewed By: ezyang

Differential Revision: D25858900

fbshipit-source-id: 16107acb3df0de18ed16d92f1e2c1b0a72e3e43d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants