Refactor build targets for torch::deploy#50288
Closed
wconstab wants to merge 1 commit intopytorch:masterfrom
Closed
Refactor build targets for torch::deploy#50288wconstab wants to merge 1 commit intopytorch:masterfrom
wconstab wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit a867954723 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
635a104 to
4aba82c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
4aba82c to
13c10a4
Compare
Codecov Report
@@ Coverage Diff @@
## master #50288 +/- ##
=======================================
Coverage 80.64% 80.65%
=======================================
Files 1913 1913
Lines 208133 208150 +17
=======================================
+ Hits 167859 167885 +26
+ Misses 40274 40265 -9 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
13c10a4 to
9c668b7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
9c668b7 to
55a3a18
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
55a3a18 to
a867954
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
a867954 to
ade3842
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
ade3842 to
4aaa8a7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
4aaa8a7 to
d93b3c3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
d93b3c3 to
d147459
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
d147459 to
c42bae5
Compare
c42bae5 to
29a3724
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
Summary: Pull Request resolved: pytorch#50288 torch::deploy will bundle the objects contained in libtorch-python together with frozenpython into a shared library. Therefore, the libtorch-python objs can't bring with them a dependency on system python. Buck TARGETS are added throughout the caffe2 tree to make available objects or headers that will be needed by torch::deploy but would have brought unsuitable dependencies if accessed using existing targets. CMakeLists are modified to separate a torch-python-objs object library which lets torch::deploy compile these objs with the same compile flags as libttorch_python used, but without some of the link-time dependencies such as python. CudaIPCTypes is moved from libtorch_python to libtorch_cuda because it is really not a python binding, and it statically registers a cuda_ipc_callback which would be duplicated if included in each copy of torch::deploy. Test Plan: no new functionality, just ensure existing tests continue to pass Reviewed By: malfet Differential Revision: D25850785 fbshipit-source-id: 45549c39b24816162ef4bb990d0d312e12d90893
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25850785 |
29a3724 to
d58274f
Compare
Contributor
|
This pull request has been merged in 4bbff92. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50288 torch::deploy will bundle the objects contained in libtorch-python together with frozenpython into a shared library. Therefore, the libtorch-python objs can't bring with them a dependency on system python. Buck TARGETS are added throughout the caffe2 tree to make available objects or headers that will be needed by torch::deploy but would have brought unsuitable dependencies if accessed using existing targets. CMakeLists are modified to separate a torch-python-objs object library which lets torch::deploy compile these objs with the same compile flags as libttorch_python used, but without some of the link-time dependencies such as python. CudaIPCTypes is moved from libtorch_python to libtorch_cuda because it is really not a python binding, and it statically registers a cuda_ipc_callback which would be duplicated if included in each copy of torch::deploy. Test Plan: no new functionality, just ensure existing tests continue to pass Reviewed By: malfet Differential Revision: D25850785 fbshipit-source-id: b0b81c050cbee04e9de96888f8a09d29238a9db8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
torch::deploy will bundle the objects contained in libtorch-python together with frozenpython into a shared library. Therefore, the libtorch-python objs can't bring with them a dependency on system python.
Buck TARGETS are added throughout the caffe2 tree to make available objects or headers that will be needed by torch::deploy but would have brought unsuitable dependencies if accessed using existing targets.
CMakeLists are modified to separate a torch-python-objs object library which lets torch::deploy compile these objs with the same compile flags as libttorch_python used, but without some of the link-time dependencies such as python.
CudaIPCTypes is moved from libtorch_python to libtorch_cuda because it is really not a python binding, and it statically registers a cuda_ipc_callback which would be duplicated if included in each copy of torch::deploy.
Differential Revision: D25850785