[FX] Support wrapping builtins with wrap#50184
Closed
jamesr66a wants to merge 11 commits intogh/jamesr66a/346/basefrom
Closed
[FX] Support wrapping builtins with wrap#50184jamesr66a wants to merge 11 commits intogh/jamesr66a/346/basefrom
jamesr66a wants to merge 11 commits intogh/jamesr66a/346/basefrom
Conversation
[ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 8898821 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 26 times. |
Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
zdevito
approved these changes
Jan 13, 2021
| def fx_len(item): | ||
| return len(item) | ||
|
|
||
| wrap(fx_len) |
Collaborator
Author
There was a problem hiding this comment.
Builtins don't have __code__:
Traceback (most recent call last):
File "test/test_fx.py", line 58, in <module>
wrap(len)
File "/data/users/jamesreed/pytorch/torch/fx/symbolic_trace.py", line 415, in wrap
fn_name = fn_or_name.__code__.co_name
AttributeError: 'builtin_function_or_method' object has no attribute '__code__'
…p()" Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
- Do some trickery to detect if we're patching a builtin that hasn't been overridden in the global frame of the wrap() caller. In this case, patch the builtin function into the global namespace but add a None sentinel to indicate we should delete the function after we're done. - Make wrap() more exception safe Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
- Do some trickery to detect if we're patching a builtin that hasn't been overridden in the global frame of the wrap() caller. In this case, patch the builtin function into the global namespace but add a None sentinel to indicate we should delete the function after we're done. - Make wrap() more exception safe Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
zdevito
approved these changes
Jan 15, 2021
- Do some trickery to detect if we're patching a builtin that hasn't been overridden in the global frame of the wrap() caller. In this case, patch the builtin function into the global namespace but add a None sentinel to indicate we should delete the function after we're done. - Make wrap() more exception safe Differential Revision: [D25819832](https://our.internmc.facebook.com/intern/diff/D25819832) [ghstack-poisoned]
Contributor
|
@jamesr66a merged this pull request in 0291f35. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#50184 Test Plan: Imported from OSS Reviewed By: bertmaher Differential Revision: D25819832 Pulled By: jamesr66a fbshipit-source-id: ab16138ee26ef2f92f3478c56f0db1873fcc5dd0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25819832