Skip to content

Unused exception variables#50181

Closed
alexhenrie wants to merge 3 commits intopytorch:masterfrom
alexhenrie:unused_e_vars
Closed

Unused exception variables#50181
alexhenrie wants to merge 3 commits intopytorch:masterfrom
alexhenrie:unused_e_vars

Conversation

@alexhenrie
Copy link
Copy Markdown
Contributor

@alexhenrie alexhenrie commented Jan 7, 2021

These unused variables were identified by pyflakes. They can be safely removed to simplify the code.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 7, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 266510f (more details on the Dr. CI page):

  • 2/3 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)
  • 1/3 broken upstream at merge base 6838ece on Jan 06 from 4:14pm to 8:39pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_bazel_build (1/1)

Step: "Bazel Build" (full log | diagnosis details | 🔁 rerun)

Jan 07 01:29:29 FAILED: Build did NOT complete successfully (39 packages loaded, 6200 targets configured) 
Jan 07 01:29:29 Repository rule http_archive defined at:
Jan 07 01:29:29   /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/bazel_tools/tools/build_defs/repo/http.bzl:336:16: in <toplevel>
Jan 07 01:29:29 WARNING: Download from https://anaconda.org/anaconda/mkl-include/2020.0/download/linux-64/mkl-include-2020.0-166.tar.bz2 failed: class java.io.IOException Read timed out
Jan 07 01:29:29 ERROR: An error occurred during the fetch of repository 'mkl_headers':
Jan 07 01:29:29    java.io.IOException: Error downloading [https://anaconda.org/anaconda/mkl-include/2020.0/download/linux-64/mkl-include-2020.0-166.tar.bz2] to /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl_headers/mkl-include-2020.0-166.tar.bz2: Read timed out
Jan 07 01:29:29 ERROR: /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl/BUILD.bazel:3:1: @mkl//:mkl depends on @mkl_headers//:mkl_headers in repository @mkl_headers which failed to fetch. no such package '@mkl_headers//': java.io.IOException: Error downloading [https://anaconda.org/anaconda/mkl-include/2020.0/download/linux-64/mkl-include-2020.0-166.tar.bz2] to /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl_headers/mkl-include-2020.0-166.tar.bz2: Read timed out
Jan 07 01:29:29 ERROR: Analysis of target '//:torch' failed; build aborted: no such package '@mkl_headers//': java.io.IOException: Error downloading [https://anaconda.org/anaconda/mkl-include/2020.0/download/linux-64/mkl-include-2020.0-166.tar.bz2] to /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/external/mkl_headers/mkl-include-2020.0-166.tar.bz2: Read timed out
Jan 07 01:29:29 INFO: Elapsed time: 252.783s
Jan 07 01:29:29 INFO: 0 processes.
Jan 07 01:29:29 FAILED: Build did NOT complete successfully (39 packages loaded, 6200 targets configured)
Jan 07 01:29:29 FAILED: Build did NOT complete successfully (39 packages loaded, 6200 targets configured)
Jan 07 01:29:29 + cleanup
Jan 07 01:29:29 + retcode=1
Jan 07 01:29:29 + set +x
Jan 07 01:29:29 =================== sccache compilation log ===================
Jan 07 01:29:29 ERROR 2021-01-07T01:25:24Z: sccache::server: ["null"] fatal error: Permission denied (os error 13) at path "/dev/.tmp1GthdB"
Jan 07 01:29:29 
Jan 07 01:29:29 ERROR 2021-01-07T01:25:24Z: sccache::server: ["null"] 	Permission denied (os error 13) at path "/dev/.tmp1GthdB"
Jan 07 01:29:29 
Jan 07 01:29:29 ERROR 2021-01-07T01:25:24Z: sccache::server: ["null"] fatal error: Permission denied (os error 13) at path "/dev/.tmpOOn0y1"
Jan 07 01:29:29

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 8 times.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jan 7, 2021
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 7, 2021
facebook-github-bot
facebook-github-bot reviewed Jan 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pritamdamania87 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 8, 2021

This pull request has been merged in 2c4b6ec.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
@alexhenrie
Unused exception variables (pytorch#50181)
38cacf2 
Summary:
These unused variables were identified by [pyflakes](https://pypi.org/project/pyflakes/). They can be safely removed to simplify the code.

Pull Request resolved: pytorch#50181

Reviewed By: gchanan

Differential Revision: D25844270

fbshipit-source-id: 0e648ffe8c6db6daf56788a13ba89806923cbb76
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@alexhenrie @facebook-github-bot
Unused exception variables (pytorch#50181)
ff44ec7 
Summary:
These unused variables were identified by [pyflakes](https://pypi.org/project/pyflakes/). They can be safely removed to simplify the code.

Pull Request resolved: pytorch#50181

Reviewed By: gchanan

Differential Revision: D25844270

fbshipit-source-id: 0e648ffe8c6db6daf56788a13ba89806923cbb76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@mrshenli mrshenli Awaiting requested review from mrshenli

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@pritamdamania87 pritamdamania87 pritamdamania87 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexhenrie @facebook-github-bot @pritamdamania87 @zou3519 @pytorchbot