Skip to content

Expose sparse variable addmm, addmm_#5016

Merged
colesbury merged 3 commits intopytorch:masterfrom
zou3519:sparse-addmm
Feb 5, 2018
Merged

Expose sparse variable addmm, addmm_#5016
colesbury merged 3 commits intopytorch:masterfrom
zou3519:sparse-addmm

Conversation

@zou3519
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 commented Feb 2, 2018

sspaddmm, mm for sparse tensors to come in another pr; they're a little more involved.

cc @colesbury

Test Plan

new unit tests

@onnxbot-worker-2 onnxbot-worker-2 mentioned this pull request Feb 2, 2018
Closed
@zou3519 zou3519 mentioned this pull request Feb 2, 2018
Merged
colesbury
colesbury reviewed Feb 2, 2018
View reviewed changes
Comment thread aten/src/ATen/Declarations.cwrap
- THTensor* mat2
- cname: spaddmm
sparse: yes
- sparse: True

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@ezyang
Copy link
Copy Markdown
Contributor

ezyang commented Feb 2, 2018

@pytorchbot retest this please

colesbury
colesbury approved these changes Feb 2, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@colesbury colesbury merged commit ba61eee into pytorch:master Feb 5, 2018
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@zou3519 @colesbury
Expose sparse variable addmm, addmm_ (pytorch#5016)
2b94cea 
sspaddmm, mm for sparse tensors to come in another pr; they're a little more involved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

+1 more reviewer

@apaszke apaszke apaszke left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zou3519 @ezyang @colesbury @apaszke