Skip to content

[Don't review] Clean up some type annotations in test/jit#50158

Closed
r-barnes wants to merge 1 commit intopytorch:masterfrom
r-barnes:export-D25717504
Closed

[Don't review] Clean up some type annotations in test/jit#50158
r-barnes wants to merge 1 commit intopytorch:masterfrom
r-barnes:export-D25717504

Conversation

@r-barnes
Copy link
Copy Markdown
Contributor

@r-barnes r-barnes commented Jan 6, 2021

Summary: Upgrades type annotations from Python2 to Python3

Test Plan: Sandcastle tests

Differential Revision: D25717504

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 6, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 4b897db (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 321b988 from Jan 06 until Jan 07

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 9 times.

@facebook-github-bot facebook-github-bot added cla signed fb-exported oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 6, 2021
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 6, 2021

This pull request was exported from Phabricator. Differential Revision: D25717504

1 similar comment
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 6, 2021

This pull request was exported from Phabricator. Differential Revision: D25717504

@r-barnes @facebook-github-bot
[Don't review] Clean up some type annotations in test/jit (pytorch#50158
4b897db 
)

Summary:
Pull Request resolved: pytorch#50158

Upgrades type annotations from Python2 to Python3

Test Plan: Sandcastle tests

Differential Revision: D25717504

fbshipit-source-id: e9d90529c69b8cfd497fb74f7bae1afe19e39574
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 7, 2021

This pull request was exported from Phabricator. Differential Revision: D25717504

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 8, 2021

This pull request has been merged in a4f30d4.

@heitorschueroff
Copy link
Copy Markdown
Contributor

heitorschueroff commented Jan 8, 2021

@r-barnes I'm unlanding this PR as it is breaking many CI builds. Here's an example https://app.circleci.com/pipelines/github/pytorch/pytorch/258501/workflows/9129a3b3-6751-4e1c-a42d-c17ae657b497/jobs/10055817.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 8, 2021

This pull request has been reverted by 1bb7d8f.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
@r-barnes
Clean up some type annotations in test/jit (pytorch#50158)
54f473e 
Summary:
Pull Request resolved: pytorch#50158

Upgrades type annotations from Python2 to Python3

Test Plan: Sandcastle tests

Reviewed By: xush6528

Differential Revision: D25717504

fbshipit-source-id: 9a83c44db02ec79f353862255732873f6d7f885e
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@r-barnes @facebook-github-bot
Clean up some type annotations in test/jit (pytorch#50158)
f72c2b5 
Summary:
Pull Request resolved: pytorch#50158

Upgrades type annotations from Python2 to Python3

Test Plan: Sandcastle tests

Reviewed By: xush6528

Differential Revision: D25717504

fbshipit-source-id: 9a83c44db02ec79f353862255732873f6d7f885e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-barnes @facebook-github-bot @heitorschueroff