Skip to content

Document single op replacement#50116

Closed
ansley wants to merge 5 commits intogh/ansleyadelaide/27/basefrom
gh/ansleyadelaide/27/head
Closed

Document single op replacement#50116
ansley wants to merge 5 commits intogh/ansleyadelaide/27/basefrom
gh/ansleyadelaide/27/head

Conversation

@ansley
Copy link
Copy Markdown

@ansley ansley commented Jan 5, 2021

Stack from ghstack:

Differential Revision: D25803457

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 5, 2021

💊 CI failures summary and remediations

As of commit 173fb5a (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 18 times.

ansley pushed a commit that referenced this pull request Jan 5, 2021
ghstack-source-id: 4e40784
Pull Request resolved: #50116
@ansley ansley requested a review from jamesr66a January 6, 2021 14:01
ansley pushed a commit that referenced this pull request Jan 6, 2021
ghstack-source-id: 83c5ff8
Pull Request resolved: #50116
Copy link
Copy Markdown
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread torch/fx/examples/replace_op.py Outdated
Comment thread torch/fx/examples/replace_op.py Outdated
ansley pushed a commit that referenced this pull request Jan 8, 2021
ghstack-source-id: b5f3480
Pull Request resolved: #50116
@ansley ansley requested a review from jamesr66a January 8, 2021 21:08
Copy link
Copy Markdown
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I added some more incremental improvement suggestions. Feel free to land when ready

Comment thread torch/fx/examples/replace_op.py Outdated
Comment thread torch/fx/examples/replace_op.py Outdated
Comment thread torch/fx/examples/replace_op.py
Comment thread torch/fx/examples/replace_op.py Outdated
Comment thread torch/fx/examples/replace_op.py
ansley pushed a commit that referenced this pull request Jan 9, 2021
ghstack-source-id: d32e739
Pull Request resolved: #50116
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ansley merged this pull request in ba1ce71.

@facebook-github-bot facebook-github-bot deleted the gh/ansleyadelaide/27/head branch January 12, 2021 15:14
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary: Pull Request resolved: pytorch#50116

Test Plan: Imported from OSS

Reviewed By: jamesr66a

Differential Revision: D25803457

Pulled By: ansley

fbshipit-source-id: de2f3c0bd037859117dde55ba677fb5da34ab639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants