Don't allow scalars where vectors are required in mv, addmv, ger, addr.#5003
Merged
gchanan merged 5 commits intopytorch:masterfrom Feb 5, 2018
Merged
Don't allow scalars where vectors are required in mv, addmv, ger, addr.#5003gchanan merged 5 commits intopytorch:masterfrom
gchanan merged 5 commits intopytorch:masterfrom
Conversation
colesbury
approved these changes
Feb 2, 2018
| } | ||
|
|
||
| static void check_1d(const Tensor& t, const char* arg, const char* fn) { | ||
| if (t.dim() == 0) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…r. (pytorch#5003) * Don't allow scalars where vectors are required in mv, addmv, ger, addr. * Fix scalar_tensor_test for ger. * Address review comments. * Fix merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.