Skip to content

Multi label margin loss#50007

Closed
v0dro wants to merge 35 commits intopytorch:masterfrom
v0dro:multi-label-margin-loss
Closed

Multi label margin loss#50007
v0dro wants to merge 35 commits intopytorch:masterfrom
v0dro:multi-label-margin-loss

Conversation

@v0dro
Copy link
Copy Markdown
Contributor

@v0dro v0dro commented Jan 3, 2021

Reopen PR for #46975

v0dro added 28 commits October 23, 2020 08:11
@v0dro
working on supplying a good test
a1885d1
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
01f5073 
…margin-loss
@v0dro
Change MultiLabelMarginLoss to accept 0-dim batch sizes
8e2a16f
@v0dro
move shape checking to separate function and reduce code duplication
0c36491
@v0dro
accept 0 dim tensor in MultiLabelMargin
02bcff1
@v0dro
update NN modules
f6626a5
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
89ede33 
…margin-loss
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
8116fd0 
…margin-loss
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
16036d5 
…margin-loss
@v0dro
remove third party apps from previous commit
6cda8b0
@v0dro
update multi label margin loss to work with JIT
c7dd5df
@v0dro
remove include iostream
6ebf017
@v0dro
some extra tests
830bde7
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
909c27f 
…margin-loss
@v0dro
update test for MultiLabel loss cehcks
02b587a
@v0dro
change checks for GPU
7ab03e1
@v0dro
update CUDA
1339074
@v0dro
update test for flake8
51526c5
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
1124e64 
…margin-loss
@v0dro
update testing and conditionals for testing
d44d86e
@v0dro
update tests
0ab92ad
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
1966220 
…margin-loss
@v0dro
chnage include headers to use angle brackets
5762783
@v0dro
revert use of angle brackets
b562139
@v0dro
update CUDA tests
3be59d9
@v0dro
multi margin loss shape check for CUDA
947aaf6
@v0dro
Merge branch 'master' of github.com:pytorch/pytorch into multi-label-…
19aa539 
…margin-loss
@v0dro
Merge branch 'multi-label-margin-loss' of github.com:v0dro/pytorch in…
e1a7c2a 
…to multi-label-margin-loss
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 3, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 76aa2ab (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 838e73d on Jan 06 from 4:14pm to 8:39pm

1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 10 times.

@v0dro
Copy link
Copy Markdown
Contributor Author

v0dro commented Jan 7, 2021

@ngimel I've reopened the PR for Multi label margin loss following failure for asan. Could you please review it again?

@v0dro v0dro marked this pull request as ready for review January 8, 2021 11:38
@gchanan gchanan requested a review from ngimel January 8, 2021 18:44
@gchanan gchanan added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 8, 2021
facebook-github-bot
facebook-github-bot reviewed Jan 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@v0dro
Copy link
Copy Markdown
Contributor Author

v0dro commented Jan 13, 2021

@rgommers any update on when this can be merged?

@rgommers
Copy link
Copy Markdown
Collaborator

rgommers commented Jan 13, 2021

@rgommers any update on when this can be merged?

It's been imported, so should be relatively soon unless there's FB-internal CI failures. That said, there's a lint failure you still need to address it looks like @v0dro. Can you please do that?

ngimel
ngimel reviewed Jan 13, 2021
View reviewed changes
Comment thread aten/src/ATen/native/LossMultiLabelMargin.cpp Outdated
@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented Jan 13, 2021 •
edited
Loading

Sorry, there's an internal build failure because of non-standard include, I thought I left the comment about it but apparently I didn't. Please fix the include.
Edit: I did leave the comment on the previous PR #46975 (comment)

facebook-github-bot
facebook-github-bot reviewed Jan 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@ngimel
Copy link
Copy Markdown
Collaborator

ngimel commented Jan 15, 2021

Can you please rebase to get rid of mypy errors?

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 18, 2021

@ngimel merged this pull request in 7f3a407.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@v0dro @facebook-github-bot
Multi label margin loss (pytorch#50007)
041efd3 
Summary:
Reopen PR for pytorch#46975

Pull Request resolved: pytorch#50007

Reviewed By: mruberry

Differential Revision: D25850808

Pulled By: ngimel

fbshipit-source-id: a232e02949182b7d3799448d24ad54a9e0bcf95c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v0dro @facebook-github-bot @rgommers @ngimel @gchanan @pytorchbot