Skip to content

torch.utils.checkpoint.checkpoint + torch.cuda.amp#49757

Closed
mcarilli wants to merge 1 commit intopytorch:masterfrom
mcarilli:autocast_checkpoint
Closed

torch.utils.checkpoint.checkpoint + torch.cuda.amp#49757
mcarilli wants to merge 1 commit intopytorch:masterfrom
mcarilli:autocast_checkpoint

Conversation

@mcarilli
Copy link
Copy Markdown
Collaborator

@mcarilli mcarilli commented Dec 22, 2020

Adds a test to orphaned original PR (#40221).

Should fix #49738 #47183 #37730

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 22, 2020

💊 CI failures summary and remediations

As of commit 4a907f2 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 3 times.

@mcarilli mcarilli changed the title test passes with diffs, fails without torch.utils.checkpoint.checkpoint + torch.cuda.amp Dec 22, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 23, 2020

Codecov Report

Merging #49757 (4a907f2) into master (7b4a766) will increase coverage by 5.35%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #49757      +/-   ##
==========================================
+ Coverage   75.20%   80.56%   +5.35%     
==========================================
  Files        1886     1890       +4     
  Lines      204860   204991     +131     
==========================================
+ Hits       154073   165154   +11081     
+ Misses      50787    39837   -10950     

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ngimel merged this pull request in ee27104.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Adds a test to orphaned original PR (pytorch#40221).

Should fix pytorch#49738 and pytorch#47183

Pull Request resolved: pytorch#49757

Reviewed By: mruberry

Differential Revision: D25689609

Pulled By: ngimel

fbshipit-source-id: 0a6adc11eb98382048ef9a9775e185dcdeff6010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

amp does not work with LayerNorm gradient checkpointing

4 participants