Skip to content

add type annotations to torch.nn.modules.fold#49479

Closed
guilhermeleobas wants to merge 2 commits intopytorch:masterfrom
guilhermeleobas:fold
Closed

add type annotations to torch.nn.modules.fold#49479
guilhermeleobas wants to merge 2 commits intopytorch:masterfrom
guilhermeleobas:fold

Conversation

@guilhermeleobas
Copy link
Copy Markdown
Collaborator

@guilhermeleobas guilhermeleobas commented Dec 16, 2020

closes gh-49478

Fixes #49478

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Dec 16, 2020
@guilhermeleobas guilhermeleobas self-assigned this Dec 16, 2020
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Dec 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit fc34956 (more details on the Dr. CI page):

  • 1/2 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 1/2 broken upstream at merge base 006cfeb from Jan 07 until Jan 08

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 8 times.

rgommers
rgommers approved these changes Dec 19, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and one CI failure is unrelated. Thanks @guilhermeleobas

@rgommers rgommers requested review from ezyang and malfet December 19, 2020 13:00
facebook-github-bot
facebook-github-bot reviewed Dec 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@guilhermeleobas guilhermeleobas mentioned this pull request Dec 31, 2020
Closed
@guilhermeleobas guilhermeleobas marked this pull request as draft December 31, 2020 17:30
@guilhermeleobas
Copy link
Copy Markdown
Collaborator Author

guilhermeleobas commented Dec 31, 2020

Do not merge this PR until one checks if the annotations introduce any regression. See:
#49564 (comment)

@guilhermeleobas guilhermeleobas marked this pull request as ready for review January 8, 2021 14:57
@guilhermeleobas
Copy link
Copy Markdown
Collaborator Author

guilhermeleobas commented Jan 8, 2021

This module is already covered by tests:

test/test_jit.py::TestJitGeneratedModule::test_nn_Fold
test/test_jit.py::TestJitGeneratedModule::test_nn_Fold_int_input
test/test_jit.py::TestJitGeneratedModule::test_nn_Unfold
test/test_jit.py::TestJitGeneratedModule::test_nn_Unfold_int_input
test/test_jit.py::TestJitGeneratedFunctional::test_nn_fold
test/test_jit.py::TestJitGeneratedFunctional::test_nn_unfold

facebook-github-bot
facebook-github-bot reviewed Jan 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 8, 2021

@walterddr merged this pull request in aa18d17.

hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
@guilhermeleobas
add type annotations to torch.nn.modules.fold (pytorch#49479)
8d40359 
Summary:
closes pytorchgh-49478

Fixes pytorch#49478

Pull Request resolved: pytorch#49479

Reviewed By: mruberry

Differential Revision: D25723838

Pulled By: walterddr

fbshipit-source-id: 45c4cbd6f147b6dc4a5f5419c17578c49c201022
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@guilhermeleobas @facebook-github-bot
add type annotations to torch.nn.modules.fold (pytorch#49479)
346a649 
Summary:
closes pytorchgh-49478

Fixes pytorch#49478

Pull Request resolved: pytorch#49479

Reviewed By: mruberry

Differential Revision: D25723838

Pulled By: walterddr

fbshipit-source-id: 45c4cbd6f147b6dc4a5f5419c17578c49c201022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@rgommers rgommers Awaiting requested review from rgommers

+2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@walterddr walterddr walterddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@guilhermeleobas guilhermeleobas

Labels

cla signed Merged module: typing Related to mypy type annotations open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable torch.nn.modules.fold typechecks during CI

6 participants

@guilhermeleobas @facebook-github-bot @rgommers @malfet @walterddr @pytorchbot