[CMake] Use libtorch_cuda list defined in bzl file#49429
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
[CMake] Use libtorch_cuda list defined in bzl file#49429malfet wants to merge 1 commit intopytorch:masterfrom
malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
Since NCCL is an optional CUDA dependency, remove nccl.cpp from the core filelist
Contributor
💊 CI failures summary and remediationsAs of commit e66de13 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 3 times. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
LGTM |
nikithamalgifb
approved these changes
Dec 15, 2020
walterddr
approved these changes
Dec 15, 2020
|
|
||
| libtorch_cuda_sources = [ | ||
| libtorch_cuda_core_sources = [ | ||
| "torch/csrc/cuda/comm.cpp", |
Contributor
There was a problem hiding this comment.
nit should we move this to libtorch_cuda_sources as well? (doesn't seem to be used anyway)
Codecov Report
@@ Coverage Diff @@
## master #49429 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 1875 1875
Lines 202702 202702
=======================================
+ Hits 163442 163444 +2
+ Misses 39260 39258 -2 |
Contributor
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 6, 2021
Summary: Since NCCL is an optional CUDA dependency, remove nccl.cpp from the core filelist Pull Request resolved: pytorch#49429 Reviewed By: nikithamalgifb Differential Revision: D25569883 Pulled By: malfet fbshipit-source-id: 61371a4c6b0438e4e0a7f094975b9a9f9ffa4032
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Since NCCL is an optional CUDA dependency, remove nccl.cpp from the core filelist Pull Request resolved: pytorch#49429 Reviewed By: nikithamalgifb Differential Revision: D25569883 Pulled By: malfet fbshipit-source-id: 61371a4c6b0438e4e0a7f094975b9a9f9ffa4032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since NCCL is an optional CUDA dependency, remove nccl.cpp from the core filelist