update breathe#49407
Conversation
💊 CI failures summary and remediationsAs of commit 1b15c2a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 3 times. |
glaringlee
left a comment
There was a problem hiding this comment.
LGTM, thanks for updating.
facebook-github-bot
left a comment
There was a problem hiding this comment.
@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
fyi there was a regression discovered, likely with the ellipsis This wasn't caught in our tests and also not in any of the projects I manually tried it with, likely a very specific edge case. You may want to keep an eye on this as there should be bugfix release for this soon. |
|
Thanks for the heads up. I am subscribed to the breathe repo. |
Codecov Report
@@ Coverage Diff @@
## master #49407 +/- ##
==========================================
- Coverage 80.56% 80.41% -0.16%
==========================================
Files 1875 1875
Lines 202701 202701
==========================================
- Hits 163307 163000 -307
- Misses 39394 39701 +307 |
|
@glaringlee merged this pull request in acd72e7. |
Summary: Fixes pytorch#47462, but not completely. Update breathe to the latest version to get fixes for the "Unable to resolve..." issues. There are still some build errors, but much fewer than before. Pull Request resolved: pytorch#49407 Reviewed By: izdeby Differential Revision: D25562163 Pulled By: glaringlee fbshipit-source-id: 91bfd9e9ac70723816309f489022d72853f5fdc5
Summary: Fixes pytorch#47462, but not completely. Update breathe to the latest version to get fixes for the "Unable to resolve..." issues. There are still some build errors, but much fewer than before. Pull Request resolved: pytorch#49407 Reviewed By: izdeby Differential Revision: D25562163 Pulled By: glaringlee fbshipit-source-id: 91bfd9e9ac70723816309f489022d72853f5fdc5
Fixes #47462, but not completely.
Update breathe to the latest version to get fixes for the "Unable to resolve..." issues. There are still some build errors, but much fewer than before.