fix test_dispatch tests to error on duplicate def#49254
Closed
bdhirsh wants to merge 5 commits intogh/bdhirsh/65/basefrom
Closed
fix test_dispatch tests to error on duplicate def#49254bdhirsh wants to merge 5 commits intogh/bdhirsh/65/basefrom
bdhirsh wants to merge 5 commits intogh/bdhirsh/65/basefrom
Conversation
[ghstack-poisoned]
Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
fbcode shows some `test_dispatch.py` tests failing after my previous PR here: #48098 https://www.internalfb.com/tasks/?t=81313176 I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running `EXPECTTEST_ACCEPT=1 python test/test_dispatch.py`, as indicated in `torch/testing/_internal/expecttest.py`. Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff). Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
Contributor
|
They should be running on OSS. At a guess, test_dispatch isn't listed in |
ezyang
approved these changes
Dec 14, 2020
fbcode shows some `test_dispatch.py` tests failing after my previous PR here: #48098 https://www.internalfb.com/tasks/?t=81313176 I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running `EXPECTTEST_ACCEPT=1 python test/test_dispatch.py`, as indicated in `torch/testing/_internal/expecttest.py`. Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff). Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
fbcode shows some `test_dispatch.py` tests failing after my previous PR here: #48098 https://www.internalfb.com/tasks/?t=81313176 I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running `EXPECTTEST_ACCEPT=1 python test/test_dispatch.py`, as indicated in `torch/testing/_internal/expecttest.py`. Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff). Differential Revision: [D25505170](https://our.internmc.facebook.com/intern/diff/D25505170) [ghstack-poisoned]
Contributor
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#49254 Test Plan: Imported from OSS Reviewed By: ezyang Differential Revision: D25505170 Pulled By: bdhirsh fbshipit-source-id: 6796f4ce022c3141934ee69c7caaa08e663adf39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fbcode shows some
test_dispatch.pytests failing after my previous PR here: #48098https://www.internalfb.com/tasks/?t=81313176
I fixed some failing tests to expect a duplicate def error, and updated the error strings expected in the tests by running
EXPECTTEST_ACCEPT=1 python test/test_dispatch.py, as indicated intorch/testing/_internal/expecttest.py.Should these tests run in OSS? It looks like they currently don't (it looks like they also didn't run in my phabricator diff).
Stack from ghstack:
Differential Revision: D25505170