Fix code review from #48659 and #48116#48731
Closed
ezyang wants to merge 2 commits intogh/ezyang/883/basefrom
Closed
Fix code review from #48659 and #48116#48731ezyang wants to merge 2 commits intogh/ezyang/883/basefrom
ezyang wants to merge 2 commits intogh/ezyang/883/basefrom
Conversation
Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced Dec 2, 2020
Closed
bhosmer
approved these changes
Dec 2, 2020
Codecov Report
@@ Coverage Diff @@
## gh/ezyang/883/base #48731 +/- ##
======================================================
- Coverage 80.83% 80.83% -0.01%
======================================================
Files 1860 1860
Lines 200668 200678 +10
======================================================
+ Hits 162218 162223 +5
- Misses 38450 38455 +5 |
ezyang
added a commit
to ezyang/pytorch
that referenced
this pull request
Dec 3, 2020
Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 1de9cce Pull Request resolved: pytorch#48731
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D25278034