Skip to content

Fix ScriptModule docstring#48608

Closed
mariosasko wants to merge 1 commit intopytorch:masterfrom
mariosasko:fix-scriptmodule-docs
Closed

Fix ScriptModule docstring#48608
mariosasko wants to merge 1 commit intopytorch:masterfrom
mariosasko:fix-scriptmodule-docs

Conversation

@mariosasko
Copy link
Copy Markdown
Contributor

@mariosasko mariosasko commented Nov 30, 2020

Fixes a typo in ScriptModule's docstring and converts it to the raw format (r"""...).

Fixes #48634

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Nov 30, 2020
@mariosasko mariosasko changed the title Fix ScriptModule docstring [WIP] Fix ScriptModule docstring Nov 30, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 30, 2020

Codecov Report

Merging #48608 (95f2980) into master (36c87f1) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #48608      +/-   ##
==========================================
- Coverage   80.92%   80.92%   -0.01%     
==========================================
  Files        1855     1855              
  Lines      200194   200194              
==========================================
- Hits       162015   162012       -3     
- Misses      38179    38182       +3     

@mariosasko mariosasko changed the title [WIP] Fix ScriptModule docstring Fix ScriptModule docstring Dec 1, 2020
@gmagogsfm gmagogsfm self-requested a review December 1, 2020 09:33
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mariosasko
Copy link
Copy Markdown
Contributor Author

@gmagogsfm Please can you merge this? Didn't know this is still open.

@gmagogsfm
Copy link
Copy Markdown
Contributor

@gmagogsfm Please can you merge this? Didn't know this is still open.

Thanks for the reminder, it fell through the crack during holidays. Will merge it.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@gmagogsfm merged this pull request in 069e68a.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Fixes a typo in `ScriptModule`'s docstring and converts it to the raw format (`r"""...`).

Fixes pytorch#48634

Pull Request resolved: pytorch#48608

Reviewed By: anjali411

Differential Revision: D25242022

Pulled By: gmagogsfm

fbshipit-source-id: 5199868af999c6c360c7dd5e2813659f1028acab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] ScriptModule docs are not properly generated

4 participants