Fix persistent_workers + pin_memory#48543
Closed
ssnl wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48543 +/- ##
=======================================
Coverage 80.94% 80.95%
=======================================
Files 1854 1854
Lines 199918 199919 +1
=======================================
+ Hits 161831 161840 +9
+ Misses 38087 38079 -8 |
ejguan
reviewed
Nov 30, 2020
| if isinstance(r, _ResumeIteration): | ||
| # Acknowledge the main process | ||
| data_queue.put(r) | ||
| data_queue.put((r, None)) |
Contributor
There was a problem hiding this comment.
Should r be the data? Maybe use worker_id as the index.
Collaborator
Author
There was a problem hiding this comment.
Well, it doesn't really matter. But I prefer _ResumeIteration being the index since integer indices are associated with actual data.
VitalyFedyunin
approved these changes
Dec 2, 2020
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Author
|
@VitalyFedyunin ping |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ejguan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 14, 2021
Summary: Fixes pytorch#48370 pytorch#47445 cc emcastillo who authored the original functionality. Pull Request resolved: pytorch#48543 Reviewed By: bdhirsh Differential Revision: D25277474 Pulled By: ejguan fbshipit-source-id: 1967002124fb0fff57caca8982bc7df359a059a2
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Fixes pytorch#48370 pytorch#47445 cc emcastillo who authored the original functionality. Pull Request resolved: pytorch#48543 Reviewed By: bdhirsh Differential Revision: D25277474 Pulled By: ejguan fbshipit-source-id: 1967002124fb0fff57caca8982bc7df359a059a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48370 #47445
cc @emcastillo who authored the original functionality.