Skip to content

Fix test_ldexp on Windows#48335

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/cast-exponents-to-int32
Closed

Fix test_ldexp on Windows#48335
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/cast-exponents-to-int32

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Nov 20, 2020

Force torch.randint to generate tensor of int32 rather than tensor of int64
Delete unneeded copies

@malfet
Fix test_ldexp on Windows
8d3e9f4 
Force randint to generate tensor of int32 rather than tensor of int64
Delete unneeded copies
@malfet malfet requested a review from ranman November 20, 2020 21:53
facebook-github-bot
facebook-github-bot reviewed Nov 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet mentioned this pull request Nov 20, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Nov 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 8d3e9f4 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 21 00:29:02 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 21 00:29:02 At: 
Nov 21 00:29:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 21 00:29:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 21 00:29:02  
Nov 21 00:29:02 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 21 00:29:02  
Nov 21 00:29:02 At: 
Nov 21 00:29:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 21 00:29:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 21 00:29:02  
Nov 21 00:29:02 [E request_callback_no_python.cpp:636] Received error while processing request type 258: RuntimeError: Can not pickle torch.futures.Future 
Nov 21 00:29:02  
Nov 21 00:29:02 At: 
Nov 21 00:29:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(98): serialize 
Nov 21 00:29:02   /opt/conda/lib/python3.8/site-packages/torch/distributed/rpc/internal.py(150): serialize 
Nov 21 00:29:02  
Nov 21 00:29:03 ok (2.551s) 
Nov 21 00:29:05   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Nov 21 00:29:05 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Nov 21 00:29:05 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend. 
Nov 21 00:29:05 RPC was initialized with the PROCESS_GROUP backend which is deprecated and slated to be removed and superseded by the TENSORPIPE backend. It is recommended to migrate to the TENSORPIPE backend.
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Nov 21, 2020

@malfet merged this pull request in dc843fe.

@malfet malfet mentioned this pull request Nov 21, 2020
Closed
@malfet malfet deleted the malfet/cast-exponents-to-int32 branch February 2, 2021 00:33
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@malfet @facebook-github-bot
Fix test_ldexp on Windows (pytorch#48335)
96a1a06 
Summary:
Force `torch.randint` to generate tensor of int32 rather than tensor of int64
Delete unneeded copies

Pull Request resolved: pytorch#48335

Reviewed By: ranman

Differential Revision: D25133312

Pulled By: malfet

fbshipit-source-id: 70bfcb6b7ff3bea611c4277e6634dc7473541288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ranman ranman ranman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @facebook-github-bot @ranman