Skip to content

Disable TestTorch.test_ldexp on Windows#48334

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/disable-test-ldexp-on-windows
Closed

Disable TestTorch.test_ldexp on Windows#48334
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/disable-test-ldexp-on-windows

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Nov 20, 2020

As it fails with:

TypeError: ufunc 'ldexp' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

@malfet
Disable TestTorch.test_ldexp on Windows
1ac7b72 
As it fails with:
```
TypeError: ufunc 'ldexp' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
```
@malfet malfet requested a review from ranman November 20, 2020 21:42
facebook-github-bot
facebook-github-bot reviewed Nov 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet malfet mentioned this pull request Nov 20, 2020
Closed
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Nov 20, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1ac7b72 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_py3_clang7_onnx_ort_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Nov 20 22:11:31 [ FAILED ] MathKernelTest.NativeLayerNorm 
Nov 20 22:11:31 Expected: true 
Nov 20 22:11:31 [  FAILED  ] MathKernelTest.NativeLayerNorm (4 ms) 
Nov 20 22:11:31 [ RUN      ] MathKernelTest.Addr 
Nov 20 22:11:31 [       OK ] MathKernelTest.Addr (1 ms) 
Nov 20 22:11:31 [----------] 3 tests from MathKernelTest (11 ms total) 
Nov 20 22:11:31  
Nov 20 22:11:31 [----------] Global test environment tear-down 
Nov 20 22:11:31 [==========] 3 tests from 1 test case ran. (11 ms total) 
Nov 20 22:11:31 [  PASSED  ] 2 tests. 
Nov 20 22:11:31 [  FAILED  ] 1 test, listed below: 
Nov 20 22:11:31 [  FAILED  ] MathKernelTest.NativeLayerNorm 
Nov 20 22:11:31  
Nov 20 22:11:31  1 FAILED TEST
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Nov 21, 2020

Abandoning in favor of #48335

@malfet malfet closed this Nov 21, 2020
@malfet malfet deleted the malfet/disable-test-ldexp-on-windows branch November 21, 2020 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ranman ranman ranman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malfet @ranman @facebook-github-bot